Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 10834308: Reland "Fix white flash when user signs out and fix wallpaper animation regression" (Closed)

Created:
8 years, 4 months ago by bshe
Modified:
8 years, 4 months ago
Reviewers:
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Reland "Fix white flash when user signs out and fix wallpaper animation regression" This CL reland CL http://codereview.chromium.org/10827284/. Previous CL was failed on some interactive ui tests. " When user signs out and transit to the login screen, the wallpaper fade in from a white screen. Described in 141563, this Cl fixed it. Also, after user login, or switch users at login screen. when wallpaper change, the new wallpaper should fade in nicely. There is a regression in recent builds. This fix fixed the regression as well. " BUG=141563, 141676, 142042 TBR=nkostylev, sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151548

Patch Set 1 #

Patch Set 2 : Fix tests #

Patch Set 3 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -50 lines) Patch
M ash/desktop_background/desktop_background_controller.cc View 1 5 chunks +17 lines, -43 lines 0 comments Download
M ash/desktop_background/desktop_background_view.cc View 1 3 chunks +22 lines, -4 lines 0 comments Download
M ash/desktop_background/desktop_background_widget_controller.h View 2 chunks +25 lines, -0 lines 0 comments Download
M ash/desktop_background/desktop_background_widget_controller.cc View 3 chunks +6 lines, -1 line 0 comments Download
M ash/root_window_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/wm/root_window_layout_manager.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698