Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1513)

Unified Diff: chrome/browser/policy/device_management_service_browsertest.cc

Issue 10834289: Split net::UploadData into two: for IPC and for upload handling (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/device_management_service_browsertest.cc
diff --git a/chrome/browser/policy/device_management_service_browsertest.cc b/chrome/browser/policy/device_management_service_browsertest.cc
index 12e5ba52aa14f2bd61ad8a688b8aa24661dff439..212c36900e02065521813f15a571162cdea030bb 100644
--- a/chrome/browser/policy/device_management_service_browsertest.cc
+++ b/chrome/browser/policy/device_management_service_browsertest.cc
@@ -50,7 +50,9 @@ class CannedResponseInterceptor : public net::URLRequest::Interceptor {
upload != NULL &&
upload->elements()->size() == 1) {
std::string response_data;
- ConstructResponse(upload->elements()->at(0).bytes(), &response_data);
+ ConstructResponse(upload->elements()->at(0).bytes(),
+ upload->elements()->at(0).bytes_length(),
+ &response_data);
return new net::URLRequestTestJob(request,
net::URLRequestTestJob::test_headers(),
response_data,
@@ -61,11 +63,11 @@ class CannedResponseInterceptor : public net::URLRequest::Interceptor {
}
private:
- void ConstructResponse(const std::vector<char>& request_data,
+ void ConstructResponse(const void* request_data,
darin (slow to review) 2012/08/15 17:49:55 nit: |const char*| instead since that's what Uploa
kinuko 2012/08/16 08:14:59 Done.
+ uint64 request_data_length,
std::string* response_data) {
em::DeviceManagementRequest request;
- ASSERT_TRUE(request.ParseFromArray(vector_as_array(&request_data),
- request_data.size()));
+ ASSERT_TRUE(request.ParseFromArray(request_data, request_data_length));
em::DeviceManagementResponse response;
if (request.has_register_request()) {
response.mutable_register_response()->set_device_management_token(

Powered by Google App Engine
This is Rietveld 408576698