Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7128)

Unified Diff: chrome/browser/ui/omnibox/extension_action_util.h

Issue 10834279: Give request-to-act badges a grey background, and increase spacing to make it fit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Finish mac support; fix pkasting's comments Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/omnibox/extension_action_util.h
diff --git a/chrome/browser/ui/omnibox/extension_action_util.h b/chrome/browser/ui/omnibox/extension_action_util.h
new file mode 100644
index 0000000000000000000000000000000000000000..c2d478bfd7b3caa4286a4e41fc71bd0df1b39754
--- /dev/null
+++ b/chrome/browser/ui/omnibox/extension_action_util.h
@@ -0,0 +1,41 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_OMNIBOX_EXTENSION_ACTION_UTIL_H_
+#define CHROME_BROWSER_UI_OMNIBOX_EXTENSION_ACTION_UTIL_H_
+
+// Utility functions for ExtensionActions that depend on code in the browser
+// component.
Peter Kasting 2012/09/11 22:27:47 Nit: Thanks for moving this to this directory. Sh
Jeffrey Yasskin 2012/09/11 23:05:28 I don't care where it lives, but I've already move
Peter Kasting 2012/09/11 23:25:41 Sorry, I didn't mean to yank your chain around on
Jeffrey Yasskin 2012/09/12 20:29:34 Done.
+
+#include "third_party/skia/include/core/SkColor.h"
+
+class ExtensionAction;
+
+namespace gfx {
+class Canvas;
+class Rect;
+}
+namespace ui {
+class ThemeProvider;
+}
+
+namespace extensions {
+
+// Paint the background and border for |action| on |tab_id|. |bounds| should
+// include the top and bottom of the location bar, and the middle column
+// exactly between two ExtensionActions, so both ExtensionActions can draw on
+// it. This background is only drawn for script badges in the WANTS_ATTENTION
+// state, and (when text is black and the background is white) consists of a
+// dark grey, 1px border and a lighter grey background with a slight vertical
+// gradient.
+void PaintExtensionActionBackground(const ExtensionAction& action,
+ int tab_id,
+ gfx::Canvas* canvas,
+ const gfx::Rect& bounds,
+ SkColor text_color,
+ SkColor background_color);
+
+} // namespace extensions
+
+#endif // CHROME_BROWSER_UI_OMNIBOX_EXTENSION_ACTION_UTIL_H_

Powered by Google App Engine
This is Rietveld 408576698