Give request-to-act badges a grey background, and increase spacing to make it fit.

chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm

Index: chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm b/chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm
index 8dc20def08c845940dd76581edb46487aa2f2a85..d82549564576948bb63fd789cac24f3f4c569406 100644
--- a/chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm
+++ b/chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm
@@ -18,7 +18,9 @@
 #import "chrome/browser/ui/cocoa/extensions/extension_action_context_menu.h"
 #import "chrome/browser/ui/cocoa/extensions/extension_popup_controller.h"
 #include "chrome/browser/ui/cocoa/last_active_browser_cocoa.h"
+#import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h"
 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
+#include "chrome/browser/ui/omnibox/location_bar_util.h"
 #include "chrome/browser/ui/tab_contents/tab_contents.h"
 #include "chrome/browser/ui/webui/extensions/extension_info_ui.h"
 #include "chrome/common/chrome_notification_types.h"
@@ -27,6 +29,7 @@
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/web_contents.h"
 #include "skia/ext/skia_utils_mac.h"
+#include "ui/gfx/canvas_skia_paint.h"
 
 using content::WebContents;
 using extensions::Extension;
@@ -94,6 +97,25 @@ CGFloat PageActionDecoration::GetWidthForSpace(CGFloat width) {
   return Extension::kPageActionIconMaxSize;
 }
 
+void PageActionDecoration::DrawInFrame(NSRect frame, NSView* control_view) {

[Scott Hess - ex-Googler, 2012/09/12 22:54:08]

I'm not entirely comfortable with this.  Having to pull in global info from the
cell feels wrong, but having to re-arrange your frame is definitely indicating a
problem.  The magic all should be baked into what is passed into here by the
cell.

I'm thinking on how to refactor, and might change my mind, but it seems like a
reasonable short-term solution would be to add a method like this to the root
decoration:

void LocationBarDecoration::DrawWithBackgroundInFrame(
    NSRect background_frame,
    NSRect frame,
    NSView* control_view) {
  DrawWithFrame(frame, control_view);
}

and then override that to accomplish your change, with the cell passing in the
right background_frame before calling DrawWithBackgroundInFrame().  Another
option would be DrawBackgroundInFrame(), so the cell could call that, then
DrawInFrame(), but that feels clunky (it works nicely with the implementation of
CanvasSkiaPaint, but doesn't feel very natural).

Well, there's also a problem that this code draws incorrectly when the
background is drawn while the field is in focus.  Is that case not possible for
some reason?  I just hard-wired to see it.

[Jeffrey Yasskin, 2012/09/14 22:13:45]

Done.
I'm not sure how to detect that the focus ring is present, and I'm not sure
exactly what the UI folks want to do in that case (change the background size to
remove those pixel rows or make it a different color?), so I'm planning to leave
it not-quite-right for now, and fix it when they make a decision.

+  {
+    CGFloat horiz_padding = [AutocompleteTextFieldCell decorationHorizontalPad];
+    frame = NSInsetRect(frame, -(horiz_padding + 1) / 2, 2);
+    gfx::Rect bounds(NSRectToCGRect(frame));
+    gfx::CanvasSkiaPaint canvas(frame, /*opaque=*/false);
+    // set_composite_alpha(true) makes the extension action paint on top of the
+    // location bar instead of whatever's behind the Chrome window.
+    canvas.set_composite_alpha(true);
+    location_bar_util::PaintExtensionActionBackground(
+        *page_action_, current_tab_id_,
+        &canvas, bounds,
+        SK_ColorBLACK, SK_ColorWHITE);
+    // Destroying |canvas| draws the background.
+  }
+
+  ImageDecoration::DrawInFrame(frame, control_view);
+}
+
 bool PageActionDecoration::AcceptsMousePress() {
   return true;
 }