Give request-to-act badges a grey background, and increase spacing to make it fit.

chrome/browser/ui/omnibox/extension_action_util.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/omnibox/extension_action_util.h"
+
+#include "chrome/browser/themes/theme_service.h"
+#include "chrome/common/extensions/extension_action.h"
+#include "third_party/skia/include/core/SkPaint.h"
+#include "third_party/skia/include/effects/SkGradientShader.h"
+#include "ui/gfx/canvas.h"
+#include "ui/gfx/color_utils.h"
+#include "ui/gfx/rect.h"
+
+namespace extensions {
+
+void PaintExtensionActionBackground(const ExtensionAction& action,
+                                    int tab_id,
+                                    gfx::Canvas* canvas,
+                                    const gfx::Rect& bounds,
+                                    SkColor text_color,
+                                    SkColor background_color) {
+  if (action.WantsAttention(tab_id)) {

[Peter Kasting, 2012/09/11 22:27:47]

Nit: Or early return so you can unindent rest of function.

[Jeffrey Yasskin, 2012/09/12 20:29:34]

Done.

+    SkPoint gradient_bounds[2] = { {SkIntToScalar(bounds.x()),
+                                    SkIntToScalar(bounds.y())},
+                                   {SkIntToScalar(bounds.x()),
+                                    SkIntToScalar(bounds.bottom())} };
+    SkColor gradient_colors[2] = {
+        color_utils::AlphaBlend(text_color, background_color, 0x13),
+        color_utils::AlphaBlend(text_color, background_color, 0x1d)
+    };
+    SkShader* gradient = SkGradientShader::CreateLinear(
+        gradient_bounds, gradient_colors, NULL, 2, SkShader::kClamp_TileMode);
+    SkPaint paint;
+    paint.setShader(gradient);
+    gradient->unref();
+    canvas->DrawRect(bounds, paint);
+
+    SkColor border_color =
+        color_utils::AlphaBlend(text_color, background_color, 0x55);
+    canvas->DrawLine(gfx::Point(bounds.x(), bounds.y()),

[Peter Kasting, 2012/09/11 22:27:47]

Nit: First arg can be "bounds.origin()"

[Jeffrey Yasskin, 2012/09/11 23:05:28]

I don't mind making this change, but it seemed more consistent to write out the
coordinates given that there's no "bottom_left()" method to match origin().

[Peter Kasting, 2012/09/11 23:25:41]

That's OK.  I'd prefer to keep the code more simple as opposed to more
parallel-structured.

[Jeffrey Yasskin, 2012/09/12 20:29:34]

Done.

+                     gfx::Point(bounds.x(), bounds.bottom()),
+                     border_color);
+    // "-1" because gfx::Rects are half-open, not including their right or
+    // bottom edges.

[Peter Kasting, 2012/09/11 22:27:47]

So two adjacent badges that request attention get a double-thickness line
between them?

That seems kinda suboptimal... maybe we could pass in an arg that says whether
to draw this line?

[Jeffrey Yasskin, 2012/09/11 23:05:28]

No, they get a single-thickness line between them. The "right()" coordinate is 1
to the right of the right-most pixel contained within the bounds. (This is
vaguely documented in ui/gfx/rect.h, and is what I mean by "half-open".) If we
have 2 badges requesting attention, "|A|B|", then A's bounds.right() points to
the x coordinate of the first pixel to the right of the line separating A and B.
B's bounds.x() will point exactly to the border between A and B.

I considered adjusting the Rect to avoid this oddity, but that seems
inconsistent with the other drawing code (DrawLine omits its final point, for
example) and with the code that retrieves object bounds. The only exception I
found is that Canvas::DrawRect, with style=stroke, draws on the right and bottom
edges of the rectangle, instead of shifting in by 1, which strikes me as an
unfixable bug rather than evidence that Rect actually uses the other model.

+    canvas->DrawLine(gfx::Point(bounds.right() - 1, bounds.y()),
+                     gfx::Point(bounds.right() - 1, bounds.bottom()),
+                     border_color);
+  }
+}
+
+}  // namespace extensions