Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 10834226: Android: don't construct PrerenderWebMediaPlayer. (Closed)

Created:
8 years, 4 months ago by Torne
Modified:
8 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Android: don't construct PrerenderWebMediaPlayer. PrerenderWebMediaPlayer derives from WebMediaPlayerImpl which is not implemented on Android (there is a separate WebMediaPlayerAndroid which is derived from the WebMediaPlayer interface). Stubbing this constructor invocation is very difficult and it's only referred to in one place, so an #ifdef is much simpler. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150774

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Torne
Hi jam@, This is needed for the webview build target but will eventually also be ...
8 years, 4 months ago (2012-08-08 12:30:12 UTC) #1
jam
lgtm
8 years, 4 months ago (2012-08-08 18:27:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/10834226/1
8 years, 4 months ago (2012-08-09 08:42:43 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 10:12:24 UTC) #4
Change committed as 150774

Powered by Google App Engine
This is Rietveld 408576698