Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: net/socket_stream/socket_stream.cc

Issue 10834215: Remove static variables from HttpStreamFactory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket_stream/socket_stream.cc
diff --git a/net/socket_stream/socket_stream.cc b/net/socket_stream/socket_stream.cc
index f656cb8b94ab447a84114c8d2f0fe72b1d70ed19..d40af4d242822ae9fc90aa34209d491ad828db4b 100644
--- a/net/socket_stream/socket_stream.cc
+++ b/net/socket_stream/socket_stream.cc
@@ -1301,9 +1301,14 @@ int SocketStream::HandleCertificateError(int result) {
SSLClientSocket* ssl_socket = static_cast<SSLClientSocket*>(socket_.get());
DCHECK(ssl_socket);
- if (HttpStreamFactory::ignore_certificate_errors() &&
- ssl_socket->IgnoreCertError(result, LOAD_IGNORE_ALL_CERT_ERRORS))
- return OK;
+ if (ssl_socket->IgnoreCertError(result, LOAD_IGNORE_ALL_CERT_ERRORS)) {
mmenke 2012/08/23 18:11:28 Could you switch this to SSLClientSocket::IgnoreCe
+ HttpTransactionFactory* factory = context_->http_transaction_factory();
+ if (factory) {
+ scoped_refptr<HttpNetworkSession> session = factory->GetSession();
+ if (session.get() && session->params().ignore_certificate_errors)
+ return OK;
+ }
+ }
if (!delegate_)
return result;

Powered by Google App Engine
This is Rietveld 408576698