Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5967)

Unified Diff: chrome/browser/ui/gtk/extensions/shell_window_gtk.h

Issue 10834205: Draggable region support for frameless app window on GTK. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/extensions/shell_window_gtk.h
diff --git a/chrome/browser/ui/gtk/extensions/shell_window_gtk.h b/chrome/browser/ui/gtk/extensions/shell_window_gtk.h
index 432edd14c938c239c743303f5c6d4a58cc75c23d..86f698dfc15127d855db02453aaebe64d9055def 100644
--- a/chrome/browser/ui/gtk/extensions/shell_window_gtk.h
+++ b/chrome/browser/ui/gtk/extensions/shell_window_gtk.h
@@ -12,11 +12,13 @@
#include "ui/base/gtk/gtk_signal.h"
#include "ui/base/x/active_window_watcher_x_observer.h"
#include "ui/gfx/rect.h"
+#include "third_party/skia/include/core/SkRegion.h"
class Profile;
namespace extensions {
class Extension;
+struct DraggableRegion;
}
class ShellWindowGtk : public ShellWindow,
@@ -55,6 +57,8 @@ class ShellWindowGtk : public ShellWindow,
// ShellWindow implementation.
virtual void SetFullscreen(bool fullscreen) OVERRIDE;
virtual bool IsFullscreenOrPending() const OVERRIDE;
+ virtual void UpdateDraggableRegions(
+ const std::vector<extensions::DraggableRegion>& regions) OVERRIDE;
virtual ~ShellWindowGtk();
@@ -64,6 +68,8 @@ class ShellWindowGtk : public ShellWindow,
GdkEventConfigure*);
CHROMEGTK_CALLBACK_1(ShellWindowGtk, gboolean, OnWindowState,
GdkEventWindowState*);
+ CHROMEGTK_CALLBACK_1(ShellWindowGtk, gboolean, OnButtonPress,
+ GdkEventButton*);
GtkWindow* window_;
GdkWindowState state_;
@@ -83,6 +89,13 @@ class ShellWindowGtk : public ShellWindow,
// fullscreen, however: some WMs don't support fullscreen.
bool content_thinks_its_fullscreen_;
+ // The region is treated as title bar, can be dragged to move,
+ // double clicked to maximize, and right clicked to open context menu.
+ scoped_ptr<SkRegion> draggable_region_;
Evan Stade 2012/08/08 21:01:42 why isn't this just an SkRegion? (empty by default
+
+ // True if the window shows without frame.
+ bool frameless_;
+
DISALLOW_COPY_AND_ASSIGN(ShellWindowGtk);
};

Powered by Google App Engine
This is Rietveld 408576698