net: Return size of upload as well as position from HttpTransaction::GetUploadProgress()

net/http/http_cache_transaction.cc

Index: net/http/http_cache_transaction.cc
diff --git a/net/http/http_cache_transaction.cc b/net/http/http_cache_transaction.cc
index d6fd59f5257906c96ef5fcb4ddb35a3a947a2c1f..381304d63d533446ec224af153975cc87fd4238d 100644
--- a/net/http/http_cache_transaction.cc
+++ b/net/http/http_cache_transaction.cc
@@ -135,7 +135,6 @@ HttpCache::Transaction::Transaction(
       read_offset_(0),
       effective_load_flags_(0),
       write_len_(0),
-      final_upload_progress_(0),
       ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)),
       ALLOW_THIS_IN_INITIALIZER_LIST(io_callback_(
           base::Bind(&Transaction::OnIOComplete,
@@ -420,7 +419,7 @@ LoadState HttpCache::Transaction::GetLoadState() const {
   return LOAD_STATE_IDLE;
 }
 
-uint64 HttpCache::Transaction::GetUploadProgress() const {
+UploadProgress HttpCache::Transaction::GetUploadProgress() const {
   if (network_trans_.get())
     return network_trans_->GetUploadProgress();
   return final_upload_progress_;

[darin (slow to review), 2012/08/29 22:05:35]

nothing seems to ever assign a value to final_upload_progress_.  perhaps this
should just return UploadProgress()?

[hashimoto, 2012/08/29 22:27:08]

HttpCache::Transaction::DoUpdateCachedResponseComplete() is assigning to it in
line 1139.