net: Return size of upload as well as position from HttpTransaction::GetUploadProgress()

net/base/upload_progress.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_BASE_UPLOAD_PROGRESS_H_
+#define NET_BASE_UPLOAD_PROGRESS_H_
+
+#include "base/basictypes.h"
+
+namespace net {
+
+class UploadProgress {
+ public:
+  UploadProgress() : size_(0), position_(0) {}
+  UploadProgress(uint64 position, uint64 size)
+      : size_(size), position_(position) {}
+
+  uint64 size() const { return size_; }

[darin (slow to review), 2012/08/29 22:53:00]

yes, this is what i had in mind.  even though UploadProgress is a simple class,
it seems like the intent is for GetUploadProgress to return snapshots of
progress.  that's why I thought this might be good as a class w/ immutable
attributes.

[willchan no longer on Chromium, 2012/08/29 23:10:02]

But now we're using operator= and the copy constructor for UploadProgress, when
we generally want to DISALLOW_COPY_AND_ASSIGN(). If we wanted to make it
immutable, why not just make the member variables const and keep it as a struct?

+  uint64 position() const { return position_; }
+
+ private:
+  uint64 size_;
+  uint64 position_;
+};
+
+}  // namespace net
+
+#endif  // NET_BASE_UPLOAD_PROGRESS_H_