Issue 10834168: Drive: Show the total size of cache files at chrome://drive-internals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834168: Drive: Show the total size of cache files at chrome://drive-internals. (Closed)

Created:
8 years, 4 months ago by yoshiki

Modified:
8 years, 4 months ago

Reviewers:
satorux1

CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Drive: Show the total size of cache files at chrome://drive-internals. BUG=135197 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150061

Patch Set 1 #

Patch Set 2 : Fix indent #

Total comments: 1

Patch Set 3 : Review (#2) fix & rebase #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -8 lines)			Patch
M	chrome/browser/resources/chromeos/drive_internals.html	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/chromeos/drive_internals.js	View	1 2	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chromeos/drive_internals_ui.cc	View		6 chunks	+22 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

yoshiki

satorux: Could you take a look? This feature enables us to make sure that the ...

8 years, 4 months ago (2012-08-04 00:47:01 UTC) #1

satorux1

8 years, 4 months ago (2012-08-04 01:28:26 UTC) #2

LGTM with a nit. 
From Nexus 7.

http://codereview.chromium.org/10834168/diff/2001/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/drive_internals.js (right):

http://codereview.chromium.org/10834168/diff/2001/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/drive_internals.js:18: * @param {Array}
gcacheSummary Dictionary of summary of GCache.
The type should be Object

Expand Messages | Collapse Messages