Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 10834164: Add message to Ash message center for no notifications (Closed)

Created:
8 years, 4 months ago by stevenjb
Modified:
8 years, 4 months ago
Reviewers:
sadrul, jennyz
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Add message to Ash message center for no notifications Also hides tray before login. BUG=137155 TBR=sky@chromium.org (for ash_strings.grd) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150101

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -24 lines) Patch
M ash/ash_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/system/status_area_widget.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 11 chunks +81 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
stevenjb
And.. one last change before the branch... (has a string change)
8 years, 4 months ago (2012-08-03 21:41:59 UTC) #1
jennyz
lgtm. http://codereview.chromium.org/10834164/diff/1/ash/system/web_notification/web_notification_tray.cc File ash/system/web_notification/web_notification_tray.cc (right): http://codereview.chromium.org/10834164/diff/1/ash/system/web_notification/web_notification_tray.cc#newcode883 ash/system/web_notification/web_notification_tray.cc:883: if (message_center_bubble()) nit: Maybe it will make the ...
8 years, 4 months ago (2012-08-03 22:37:58 UTC) #2
stevenjb
http://codereview.chromium.org/10834164/diff/1/ash/system/web_notification/web_notification_tray.cc File ash/system/web_notification/web_notification_tray.cc (right): http://codereview.chromium.org/10834164/diff/1/ash/system/web_notification/web_notification_tray.cc#newcode883 ash/system/web_notification/web_notification_tray.cc:883: if (message_center_bubble()) On 2012/08/03 22:37:58, jennyz wrote: > nit: ...
8 years, 4 months ago (2012-08-03 23:29:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10834164/8001
8 years, 4 months ago (2012-08-03 23:29:35 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-03 23:29:42 UTC) #5
Presubmit check for 10834164-8001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ash

Presubmit checks took 1.0s to calculate.

Powered by Google App Engine
This is Rietveld 408576698