Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 10834144: Extensions Docs Server: Split apps from extensions (Closed)

Created:
8 years, 4 months ago by cduvall
Modified:
8 years, 4 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, clintstaley
Visibility:
Public.

Description

Extensions Docs Server: Split apps from extensions The apps and extensions templates are now in separate directories. I didn't customize the intros (like removing sections marked class="doc-family apps"), because the conversion script will have to do that. Unfortunately, it looks like the current docs system just uses a list of non-apps APIs to tell the difference between apps and extensions APIs: http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/common/extensions/docs/js/api_page_generator.js&exact_package=chromium&q=listChromeAPI&type=cs&l=546 BUG=139897, 140251, 140270 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150159

Patch Set 1 : #

Total comments: 2

Patch Set 2 : reworked #

Total comments: 14

Patch Set 3 : fixes #

Total comments: 12

Patch Set 4 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -412 lines) Patch
M chrome/common/extensions/docs/server2/api_list_data_source.py View 1 2 2 chunks +15 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/server2/branch_utility.py View 1 1 chunk +9 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/handler.py View 1 2 3 2 chunks +10 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/server2/integration_test.py View 1 2 2 chunks +12 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/server2/template_data_source.py View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/articles/api_index.html View 1 2 3 3 chunks +17 lines, -7 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/articles/experimental.html View 1 2 3 6 chunks +17 lines, -1 line 0 comments Download
A chrome/common/extensions/docs/server2/templates/private/apps_sidenav.html View 1 chunk +57 lines, -0 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/private/extensions_sidenav.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/server2/templates/private/footer.html View 1 2 3 2 chunks +13 lines, -6 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/sidenav.html View 1 chunk +0 lines, -88 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/private/standard_api.html View 1 chunk +0 lines, -32 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/private/standard_apps_api.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/private/standard_apps_article.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/templates/private/standard_article.html View 1 1 chunk +0 lines, -21 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/private/standard_extensions_api.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/private/standard_extensions_article.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/about_apps.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/alarms.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/api_index.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/appWindow.html View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/about_apps.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/alarms.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/api_index.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/appWindow.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/bookmarks.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/browsingData.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/contentSettings.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/contextMenus.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/cookies.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/debugger.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/declarativeWebRequest.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/devtools.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/devtools_inspectedWindow.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/devtools_network.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/devtools_panels.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/downloads.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/experimental.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/experimental_accessibility.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/experimental_app.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/experimental_bluetooth.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/experimental_bookmarkManager.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/experimental_devtools.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/experimental_devtools_resources.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/experimental_dns.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/experimental_identity.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/experimental_input_virtualKeyboard.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/experimental_mediaGalleries.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/experimental_record.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/experimental_rlz.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/experimental_serial.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/experimental_usb.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/fileSystem.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/history.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/i18n.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/idle.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/public/apps/index.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/management.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/pageCapture.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/permissions.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/privacy.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/proxy.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/runtime.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/socket.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/storage.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/tabs.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/topSites.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/tts.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/ttsEngine.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/types.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/webNavigation.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/webRequest.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/apps/webstore.html View 1 1 chunk +1 line, -0 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/bookmarks.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/browserAction.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/browsingData.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/contentSettings.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/contextMenus.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/cookies.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/debugger.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/declarativeWebRequest.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/devtools.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/devtools_inspectedWindow.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/devtools_network.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/devtools_panels.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/downloads.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_accessibility.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_app.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_bluetooth.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_bookmarkManager.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_commands.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_devtools.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_devtools_audits.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_devtools_console.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_devtools_resources.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_discovery.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_dns.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_identity.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_infobars.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_input_virtualKeyboard.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_mediaGalleries.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_offscreenTabs.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_processes.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_record.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_rlz.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_serial.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_speechInput.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/experimental_usb.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/extension.html View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/alarms.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/api_index.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/bookmarks.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/browserAction.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/browsingData.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/contentSettings.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/contextMenus.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/cookies.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/debugger.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/declarativeWebRequest.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/devtools.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/devtools_inspectedWindow.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/devtools_network.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/devtools_panels.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/experimental.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/experimental_accessibility.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/experimental_app.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/experimental_bluetooth.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/experimental_bookmarkManager.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/experimental_commands.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/experimental_devtools.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/experimental_devtools_audits.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/experimental_devtools_console.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/experimental_devtools_resources.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/experimental_discovery.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/experimental_identity.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/experimental_infobars.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/experimental_input_virtualKeyboard.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/experimental_offscreenTabs.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/experimental_processes.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/experimental_record.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/experimental_rlz.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/experimental_speechInput.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/extension.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/fileBrowserHandler.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/fontSettings.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/history.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/i18n.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/idle.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/public/extensions/index.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/input_ime.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/management.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/omnibox.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/pageAction.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/pageCapture.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/permissions.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/privacy.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/proxy.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/runtime.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/common/extensions/docs/server2/templates/public/extensions/samples.html View 1 1 chunk +1 line, -1 line 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/scriptBadge.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/storage.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/tabs.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/topSites.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/tts.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/ttsEngine.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/types.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/webNavigation.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/webRequest.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/webstore.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/templates/public/extensions/windows.html View 1 1 chunk +1 line, -0 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/fileBrowserHandler.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/fileSystem.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/fontSettings.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/history.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/i18n.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/idle.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/index.html View 1 chunk +0 lines, -100 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/input_ime.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/management.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/omnibox.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/pageAction.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/pageCapture.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/permissions.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/privacy.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/proxy.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/runtime.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/samples.html View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/scriptBadge.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/socket.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/storage.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/tabs.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/topSites.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/tts.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/ttsEngine.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/types.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/webNavigation.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/webRequest.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/webstore.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/windows.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
cduvall
8 years, 4 months ago (2012-08-03 00:59:58 UTC) #1
not at google - send to devlin
This change doesn't need to be so magical. It only needs to be by convention ...
8 years, 4 months ago (2012-08-03 20:05:29 UTC) #2
cduvall
Reworked according to your comment. https://chromiumcodereview.appspot.com/10834144/diff/2001/chrome/common/extensions/docs/server2/handler.py File chrome/common/extensions/docs/server2/handler.py (right): https://chromiumcodereview.appspot.com/10834144/diff/2001/chrome/common/extensions/docs/server2/handler.py#newcode52 chrome/common/extensions/docs/server2/handler.py:52: EXTENSIONS_TEMPLATE_PATH = DOCS_PATH + ...
8 years, 4 months ago (2012-08-03 22:37:59 UTC) #3
not at google - send to devlin
look great, only a couple of comments. http://codereview.chromium.org/10834144/diff/7001/chrome/common/extensions/docs/server2/api_list_data_source.py File chrome/common/extensions/docs/server2/api_list_data_source.py (right): http://codereview.chromium.org/10834144/diff/7001/chrome/common/extensions/docs/server2/api_list_data_source.py#newcode22 chrome/common/extensions/docs/server2/api_list_data_source.py:22: return_dict = ...
8 years, 4 months ago (2012-08-06 08:38:33 UTC) #4
cduvall
See branch_utility for comments on docs paths. http://codereview.chromium.org/10834144/diff/7001/chrome/common/extensions/docs/server2/api_list_data_source.py File chrome/common/extensions/docs/server2/api_list_data_source.py (right): http://codereview.chromium.org/10834144/diff/7001/chrome/common/extensions/docs/server2/api_list_data_source.py#newcode22 chrome/common/extensions/docs/server2/api_list_data_source.py:22: return_dict = ...
8 years, 4 months ago (2012-08-06 18:36:16 UTC) #5
not at google - send to devlin
lgtm http://codereview.chromium.org/10834144/diff/4007/chrome/common/extensions/docs/server2/handler.py File chrome/common/extensions/docs/server2/handler.py (right): http://codereview.chromium.org/10834144/diff/4007/chrome/common/extensions/docs/server2/handler.py#newcode119 chrome/common/extensions/docs/server2/handler.py:119: real_path = 'extensions/index.html' would be nice to do ...
8 years, 4 months ago (2012-08-06 22:01:23 UTC) #6
not at google - send to devlin
... and just checking, the build.py stuff definitely works?
8 years, 4 months ago (2012-08-06 22:02:00 UTC) #7
cduvall
On 2012/08/06 22:02:00, kalman wrote: > ... and just checking, the build.py stuff definitely works? ...
8 years, 4 months ago (2012-08-06 22:07:51 UTC) #8
cduvall
8 years, 4 months ago (2012-08-06 22:25:45 UTC) #9
http://codereview.chromium.org/10834144/diff/4007/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/handler.py (right):

http://codereview.chromium.org/10834144/diff/4007/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/handler.py:119: real_path =
'extensions/index.html'
On 2012/08/06 22:01:24, kalman wrote:
> would be nice to do a webserver-y kind of thing and detect that these are
> directories and serve index.html out of them (so like, generic handling code).
> But that'd be a pain cos of all this come-from-subversion stuff.
> 
> TODO?

Done.

http://codereview.chromium.org/10834144/diff/4007/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/template_data_source.py (right):

http://codereview.chromium.org/10834144/diff/4007/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/template_data_source.py:115: 'FALSE':
False
On 2012/08/06 22:01:24, kalman wrote:
> hah! nice.
> 
> (would have preferred lower case though)

Done.

http://codereview.chromium.org/10834144/diff/4007/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/templates/articles/api_index.html
(right):

http://codereview.chromium.org/10834144/diff/4007/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/templates/articles/api_index.html:8:
{{?is_apps}}<p class="doc-family apps">
On 2012/08/06 22:01:24, kalman wrote:
> why not using {{:}} and having this on the same line and stuff? I would have
> expected it to look like
> 
> {{?is_apps}}
> ..
> {{:is_apps}}
> ..
> {{/is_apps}}

Done.

http://codereview.chromium.org/10834144/diff/4007/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/templates/articles/api_index.html:25:
{{:}}
On 2012/08/06 22:01:24, kalman wrote:
> getting hard to read without explicitly naming what these are, so like, make
it
> {{:is_apps}}

Done.

http://codereview.chromium.org/10834144/diff/4007/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/templates/articles/experimental.html
(right):

http://codereview.chromium.org/10834144/diff/4007/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/templates/articles/experimental.html:2:
{{^is_apps}}<div class="doc-family extensions">
On 2012/08/06 22:01:24, kalman wrote:
> same comments as before

Done.

http://codereview.chromium.org/10834144/diff/4007/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/templates/private/footer.html
(right):

http://codereview.chromium.org/10834144/diff/4007/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/templates/private/footer.html:14:
window.bootstrap = {
On 2012/08/06 22:01:24, kalman wrote:
> you could move the checks inside the { so that branchInfo (and any other
future
> bootstrap data) isn't repeated?

Done.

Powered by Google App Engine
This is Rietveld 408576698