chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc - Issue 10834108: Replace InputMethodEngineIBus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

Issue 10834108: Replace InputMethodEngineIBus. (Closed) Base URL: http://git.chromium.org/chromium/src.git@input_method_engine_ibus

Patch Set: Fix wrong DCHECK and it's description Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/input_method/input_method_engine_ibus.cc ('K') | « chrome/browser/chromeos/input_method/input_method_manager_impl.cc ('k') | chrome/browser/chromeos/input_method/mock_input_method_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc b/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

index 89a1f87bb60f363c7ef81e26171bef8a2d927cb6..524db6ffdd5260a08ba1a302ad1c164a7f047b2f 100644

--- a/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

+++ b/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

@@ -809,7 +809,8 @@ TEST_F(InputMethodManagerImplTest, TestAddRemoveExtensionInputMethods) {

std::string(kExtensionImePrefix) + "deadbeef",

"deadbeef input method",

layouts,

- "en-US");

+ "en-US",

+ NULL);

EXPECT_EQ(2U, manager_->GetNumActiveInputMethods());

EXPECT_EQ(1, controller_->start_count_); // should be started.

{

@@ -824,7 +825,8 @@ TEST_F(InputMethodManagerImplTest, TestAddRemoveExtensionInputMethods) {

std::string(kExtensionImePrefix) + "cafebabe",

"cafebabe input method",

layouts,

- "en-US");

+ "en-US",

+ NULL);

EXPECT_EQ(3U, manager_->GetNumActiveInputMethods());

{

scoped_ptr<InputMethodDescriptors> methods(

@@ -867,7 +869,8 @@ TEST_F(InputMethodManagerImplTest, TestAddExtensionInputThenLockScreen) {

std::string(kExtensionImePrefix) + "deadbeef",

"deadbeef input method",

layouts,

- "en-US");

+ "en-US",

+ NULL);

EXPECT_EQ(2U, manager_->GetNumActiveInputMethods());

EXPECT_EQ(1, observer.input_method_changed_count_);