Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager.h

Issue 10834108: Replace InputMethodEngineIBus. (Closed) Base URL: http://git.chromium.org/chromium/src.git@input_method_engine_ibus
Patch Set: Fix wrong DCHECK and it's description Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_manager.h
diff --git a/chrome/browser/chromeos/input_method/input_method_manager.h b/chrome/browser/chromeos/input_method/input_method_manager.h
index 137173d3a8a383ff9eefb61f1359036a29484fd4..c93d53c155e39f3b203511814f2b6ebb0d7dbe0a 100644
--- a/chrome/browser/chromeos/input_method/input_method_manager.h
+++ b/chrome/browser/chromeos/input_method/input_method_manager.h
@@ -7,6 +7,7 @@
#include <map>
#include <string>
+#include <vector>
#include "base/logging.h" // for NOTIMPLEMENTED()
#include "chrome/browser/chromeos/input_method/input_method_config.h"
@@ -19,6 +20,7 @@ class Accelerator;
} // namespace ui
namespace chromeos {
+class InputMethodEngine;
namespace input_method {
class XKeyboard;
@@ -116,11 +118,13 @@ class InputMethodManager {
const std::string& config_name,
const InputMethodConfigValue& value) = 0;
- // Adds an input method extension.
+ // Adds an input method extension. This function does not takes ownership of
+ // |instance|.
virtual void AddInputMethodExtension(const std::string& id,
const std::string& name,
const std::vector<std::string>& layouts,
- const std::string& language) = 0;
+ const std::string& language,
+ InputMethodEngine* instance) = 0;
// Removes an input method extension.
virtual void RemoveInputMethodExtension(const std::string& id) = 0;

Powered by Google App Engine
This is Rietveld 408576698