Replace InputMethodEngineIBus.

Replace InputMethodEngineIBus.

This CL removes libibus dependent code.
This CL does not provide functionally changes into extension IME.
This CL does not provide any unittests for input_method_engine_ibus.{cc|h}. Let me split CL for simplicity.

BUG=126947
TEST=Try bots and manually check the extension IME works on Lumpy.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150497

[Seigo Nonaka, 2012-08-06 05:50:31]

Hi zork@,

I'm sorry for large CL, but could you take a look?
Thanks.

[Zachary Kuznia, 2012-08-07 06:41:03]

lgtm

http://codereview.chromium.org/10834108/diff/1049/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/input_method_engine_ibus.cc (right):

http://codereview.chromium.org/10834108/diff/1049/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/input_method_engine_ibus.cc:562: //
TODO(nona): Implement error handling.
Log an error here.

http://codereview.chromium.org/10834108/diff/1049/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/input_method_engine_ibus.cc:569: const
std::string kObjectPathPrefix = "/org/freedesktop/IBus/Engine/";
Put this constant at the top of the file.

http://codereview.chromium.org/10834108/diff/1049/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/input_method_engine_ibus.h (right):

http://codereview.chromium.org/10834108/diff/1049/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/input_method_engine_ibus.h:46: //
InputMethodEngine override.
You should only need this comment once for all the InputMethodEngine functions.

http://codereview.chromium.org/10834108/diff/1049/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/input_method_engine_ibus.h:103: //
IBusEngineHandlerInterface override.
Ditto

[Seigo Nonaka, 2012-08-07 17:39:21]

zork:
Thank you for your quick review!

+ben@ as a owner of chrome/chrome_browser.gypi

Thanks,
Seigo.

http://codereview.chromium.org/10834108/diff/1049/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/input_method_engine_ibus.cc (right):

http://codereview.chromium.org/10834108/diff/1049/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/input_method_engine_ibus.cc:562: //
TODO(nona): Implement error handling.
On 2012/08/07 06:41:04, Zachary Kuznia wrote:
> Log an error here.

Done.

http://codereview.chromium.org/10834108/diff/1049/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/input_method_engine_ibus.cc:569: const
std::string kObjectPathPrefix = "/org/freedesktop/IBus/Engine/";
On 2012/08/07 06:41:04, Zachary Kuznia wrote:
> Put this constant at the top of the file.

Done.

http://codereview.chromium.org/10834108/diff/1049/chrome/browser/chromeos/inp...
File chrome/browser/chromeos/input_method/input_method_engine_ibus.h (right):

http://codereview.chromium.org/10834108/diff/1049/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/input_method_engine_ibus.h:46: //
InputMethodEngine override.
On 2012/08/07 06:41:04, Zachary Kuznia wrote:
> You should only need this comment once for all the InputMethodEngine
functions.

Done.

http://codereview.chromium.org/10834108/diff/1049/chrome/browser/chromeos/inp...
chrome/browser/chromeos/input_method/input_method_engine_ibus.h:103: //
IBusEngineHandlerInterface override.
On 2012/08/07 06:41:04, Zachary Kuznia wrote:
> Ditto

Done.

[Ben Goodger (Google), 2012-08-07 19:41:47]

lgtm

[commit-bot: I haz the power, 2012-08-08 02:50:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/10834108/1051

[commit-bot: I haz the power, 2012-08-08 04:37:58]

Change committed as 150497