Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7548)

Unified Diff: chrome/common/extensions/extension.h

Issue 10834106: Implement Keybinding for script badges. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.h
===================================================================
--- chrome/common/extensions/extension.h (revision 149159)
+++ chrome/common/extensions/extension.h (working copy)
@@ -606,19 +606,25 @@
}
// The browser action command that the extension wants to use, which is not
// necessarily the one it can use, as it might be inactive (see also
- // GetActiveBrowserActionCommand in ExtensionKeybindingRegistry).
+ // GetBrowserActionCommand in CommandService).
const extensions::Command* browser_action_command() const {
return browser_action_command_.get();
}
// The page action command that the extension wants to use, which is not
// necessarily the one it can use, as it might be inactive (see also
- // GetActivePageActionCommand in ExtensionKeybindingRegistry).
+ // GetPageActionCommand in CommandService).
const extensions::Command* page_action_command() const {
return page_action_command_.get();
}
+ // The script badge command that the extension wants to use, which is not
+ // necessarily the one it can use, as it might be inactive (see also
+ // GetScriptBadgeCommand in CommandService).
+ const extensions::Command* script_badge_command() const {
+ return script_badge_command_.get();
+ }
// The map (of command names to commands) that the extension wants to use,
// which is not necessarily the one it can use, as they might be inactive
- // (see also GetActiveNamedCommands in ExtensionKeybindingRegistry).
+ // (see also GetNamedCommands in CommandService).
const extensions::CommandMap& named_commands() const {
return named_commands_;
}
@@ -996,6 +1002,7 @@
// Optional list of commands (keyboard shortcuts).
scoped_ptr<extensions::Command> browser_action_command_;
scoped_ptr<extensions::Command> page_action_command_;
+ scoped_ptr<extensions::Command> script_badge_command_;
extensions::CommandMap named_commands_;
// Optional list of web accessible extension resources.

Powered by Google App Engine
This is Rietveld 408576698