Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3837)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/location_bar/page_action_image_view.h

Issue 10834106: Implement Keybinding for script badges. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/gtk/location_bar_view_gtk.cc ('K') | « chrome/browser/ui/views/browser_action_view.cc ('k') | chrome/browser/ui/views/location_bar/page_action_image_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/location_bar/page_action_image_view.h
===================================================================
--- chrome/browser/ui/views/location_bar/page_action_image_view.h (revision 149159)
+++ chrome/browser/ui/views/location_bar/page_action_image_view.h (working copy)
@@ -129,9 +129,12 @@
content::NotificationRegistrar registrar_;
- // The extension keybinding accelerator this page action is listening for (to
+ // The extension command accelerator this page action is listening for (to
// show the popup).
- scoped_ptr<ui::Accelerator> keybinding_;
+ scoped_ptr<ui::Accelerator> page_action_keybinding_;
+ // The extension command accelerator this script badge is listening for (to
sky 2012/08/02 15:12:46 nit: newline between 134/135.
+ // show the popup).
+ scoped_ptr<ui::Accelerator> script_badge_keybinding_;
scoped_ptr<views::MenuRunner> menu_runner_;
« chrome/browser/ui/gtk/location_bar_view_gtk.cc ('K') | « chrome/browser/ui/views/browser_action_view.cc ('k') | chrome/browser/ui/views/location_bar/page_action_image_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698