Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3945)

Unified Diff: chrome/common/extensions/command.cc

Issue 10834106: Implement Keybinding for script badges. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/command.cc
===================================================================
--- chrome/common/extensions/command.cc (revision 149159)
+++ chrome/common/extensions/command.cc (working copy)
@@ -231,9 +231,11 @@
command_name_ = command_name;
if (command_name !=
- extension_manifest_values::kPageActionKeybindingEvent &&
+ extension_manifest_values::kPageActionCommandEvent &&
command_name !=
- extension_manifest_values::kBrowserActionKeybindingEvent) {
+ extension_manifest_values::kBrowserActionCommandEvent &&
+ command_name !=
+ extension_manifest_values::kScriptBadgeCommandEvent) {
if (!command->GetString(keys::kDescription, &description_) ||
description_.empty()) {
*error = ExtensionErrorUtils::FormatErrorMessageUTF16(
@@ -252,8 +254,9 @@
DictionaryValue* extension_data = new DictionaryValue();
string16 command_description;
- if (command_name() == values::kBrowserActionKeybindingEvent ||
- command_name() == values::kPageActionKeybindingEvent) {
+ if (command_name() == values::kBrowserActionCommandEvent ||
+ command_name() == values::kPageActionCommandEvent ||
+ command_name() == values::kScriptBadgeCommandEvent) {
command_description =
l10n_util::GetStringUTF16(IDS_EXTENSION_COMMANDS_GENERIC_ACTIVATE);
} else {

Powered by Google App Engine
This is Rietveld 408576698