chrome/browser/ui/views/location_bar/page_action_image_view.h - Issue 10834106: Implement Keybinding for script badges.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/page_action_image_view.h

Issue 10834106: Implement Keybinding for script badges. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/location_bar/page_action_image_view.h

===================================================================

--- chrome/browser/ui/views/location_bar/page_action_image_view.h (revision 149159)

+++ chrome/browser/ui/views/location_bar/page_action_image_view.h (working copy)

@@ -129,9 +129,12 @@

content::NotificationRegistrar registrar_;

- // The extension keybinding accelerator this page action is listening for (to

+ // The extension command accelerator this page action is listening for (to

// show the popup).

- scoped_ptr<ui::Accelerator> keybinding_;

+ scoped_ptr<ui::Accelerator> keybinding_page_action_;

Yoyo Zhou 2012/08/02 09:59:29 How about page_action_keybinding_? Seems to fit mo

+ // The extension command accelerator this script badge is listening for (to

+ // show the popup).

+ scoped_ptr<ui::Accelerator> keybinding_script_badge_;

scoped_ptr<views::MenuRunner> menu_runner_;