Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6294)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/extension_keybinding_registry.cc

Issue 10834106: Implement Keybinding for script badges. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/extension_keybinding_apitest.cc ('K') | « chrome/browser/extensions/extension_keybinding_apitest.cc ('k') | chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc » ('j') | chrome/browser/ui/views/location_bar/page_action_image_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_keybinding_registry.cc
===================================================================
--- chrome/browser/extensions/extension_keybinding_registry.cc (revision 149159)
+++ chrome/browser/extensions/extension_keybinding_registry.cc (working copy)
@@ -41,8 +41,9 @@
bool ExtensionKeybindingRegistry::ShouldIgnoreCommand(
const std::string& command) const {
- return command == extension_manifest_values::kPageActionKeybindingEvent ||
- command == extension_manifest_values::kBrowserActionKeybindingEvent;
+ return command == extension_manifest_values::kPageActionCommandEvent ||
+ command == extension_manifest_values::kBrowserActionCommandEvent ||
+ command == extension_manifest_values::kScriptBadgeCommandEvent;
}
void ExtensionKeybindingRegistry::Observe(
« chrome/browser/extensions/extension_keybinding_apitest.cc ('K') | « chrome/browser/extensions/extension_keybinding_apitest.cc ('k') | chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc » ('j') | chrome/browser/ui/views/location_bar/page_action_image_view.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698