Allow the user to drag a window from one display to another

ash/wm/default_window_resizer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/default_window_resizer.h"
 
 #include "ash/shell.h"
 #include "ash/wm/coordinate_conversion.h"
 #include "ash/wm/cursor_manager.h"
 #include "ui/aura/client/aura_constants.h"
@@ skipping 21 matching lines @@
   Details details(window, location, window_component);
   return details.is_resizable ? new DefaultWindowResizer(details) : NULL;
 }
 
 void DefaultWindowResizer::Drag(const gfx::Point& location, int event_flags) {
   std::pair<aura::RootWindow*, gfx::Point> actual_location =
       wm::GetRootWindowRelativeToWindow(details_.window->parent(), location);
 
   // TODO(mazda|yusukes): Implement dragging an item from one display to another
   aura::RootWindow* current_root = actual_location.first;
+  gfx::Point location_in_screen = actual_location.second;
+  wm::ConvertPointToScreen(current_root, &location_in_screen);
   if (current_root != details_.window->GetRootWindow())
     return;
 
   int grid_size = event_flags & ui::EF_CONTROL_DOWN ?
                   0 : ash::Shell::GetInstance()->GetGridSize();
-  gfx::Rect bounds(CalculateBoundsForDrag(details_, location, grid_size));
+  gfx::Rect bounds(
+      CalculateBoundsForDrag(details_, location_in_screen, grid_size));

[sky, 2012/08/06 20:45:03]

Why are any of these in screen coordinates?

[Yusuke Sato, 2012/08/06 21:36:41]

Thanks, it's better to keep using the original coordinates. Reverted changes
against wm/default_window_resizer.cc and wm/window_resizer.*.

   if (bounds != details_.window->bounds()) {
     did_move_or_resize_ = true;
     details_.window->SetBounds(bounds);
   }
 }
 
 void DefaultWindowResizer::CompleteDrag(int event_flags) {
   int grid_size = event_flags & ui::EF_CONTROL_DOWN ?
                   0 : ash::Shell::GetInstance()->GetGridSize();
   if (grid_size <= 1 || !did_move_or_resize_)
@@ skipping 24 matching lines @@
 }
 
 DefaultWindowResizer::DefaultWindowResizer(const Details& details)
     : details_(details),
       did_move_or_resize_(false) {
   DCHECK(details_.is_resizable);
   ash::Shell::GetInstance()->cursor_manager()->LockCursor();
 }
 
 }  // namespace aura