Bug fix for lack of errors on requests with invalid ports

Bug fix for lack of errors on requests with invalid ports

BUG=http://code.google.com/p/chromium/issues/detail?id=138735


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148925

[shalev, 2012-07-27 18:39:46]

Hi Matt,

This cl fixes the bug you discovered in which the ftp protocol handler does not
return errors. Please take a look.

Shalev

[mmenke, 2012-07-27 19:12:22]

LGTM

http://codereview.chromium.org/10834053/diff/1/net/url_request/ftp_protocol_h...
File net/url_request/ftp_protocol_handler.cc (right):

http://codereview.chromium.org/10834053/diff/1/net/url_request/ftp_protocol_h...
net/url_request/ftp_protocol_handler.cc:9: #include "net/base/net_util.h"
Should probably include "googleurl/src/gurl.h" as well.

[mmenke, 2012-07-27 19:44:43]

We may also want a regression test for this.

[shalev, 2012-07-30 02:27:00]

http://codereview.chromium.org/10834053/diff/1/net/url_request/ftp_protocol_h...
File net/url_request/ftp_protocol_handler.cc (right):

http://codereview.chromium.org/10834053/diff/1/net/url_request/ftp_protocol_h...
net/url_request/ftp_protocol_handler.cc:9: #include "net/base/net_util.h"
On 2012/07/27 19:12:22, Matt Menke wrote:
> Should probably include "googleurl/src/gurl.h" as well.

Done.

[commit-bot: I haz the power, 2012-07-30 02:31:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shalev@chromium.org/10834053/1002

[commit-bot: I haz the power, 2012-07-30 04:16:39]

Change committed as 148925