Refactor of Histogram related code

chrome/common/metrics/metrics_log_base.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/metrics/metrics_log_base.h"
 
 #include "base/base64.h"
 #include "base/basictypes.h"
 #include "base/md5.h"
 #include "base/perftimer.h"
@@ skipping 434 matching lines @@
 
 // TODO(JAR): A The following should really be part of the histogram class.
 // Internal state is being needlessly exposed, and it would be hard to reuse
 // this code. If we moved this into the Histogram class, then we could use
 // the same infrastructure for logging StatsCounters, RatesCounters, etc.
 void MetricsLogBase::RecordHistogramDelta(
     const Histogram& histogram,
     const Histogram::SampleSet& snapshot) {
   DCHECK(!locked_);
   DCHECK_NE(0, snapshot.TotalCount());
-  snapshot.CheckSize(histogram);
+  DCHECK_EQ(histogram.bucket_count(), snapshot.size());
 
   // We will ignore the MAX_INT/infinite value in the last element of range[].
 
   OPEN_ELEMENT_FOR_SCOPE("histogram");
 
   std::string base64_name_hash;
   uint64 numeric_name_hash;
   CreateHashes(histogram.histogram_name(),
                &base64_name_hash,
                &numeric_name_hash);
@@ skipping 22 matching lines @@
   for (size_t i = 0; i < histogram.bucket_count(); ++i) {
     if (snapshot.counts(i)) {
       HistogramEventProto::Bucket* bucket = histogram_proto->add_bucket();
       bucket->set_min(histogram.ranges(i));
       bucket->set_max(histogram.ranges(i + 1));
       bucket->set_bucket_index(i);
       bucket->set_count(snapshot.counts(i));
     }
   }
 }