chrome/browser/extensions/extension_service_unittest.cc - Issue 10834004: Correct const accessors in base/values.(h|cc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 10834004: Correct const accessors in base/values.(h|cc) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more, Windows-only Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_prefs.cc ('k') | chrome/browser/extensions/extension_web_ui.cc » ('j') | chrome/test/webdriver/commands/cookie_commands.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service_unittest.cc

diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc

index b31244a01a661381b6563288727f2c66a7961b2c..40a25b11b25e8a6f4c3826eabee9e6acf22eef9f 100644

--- a/chrome/browser/extensions/extension_service_unittest.cc

+++ b/chrome/browser/extensions/extension_service_unittest.cc

@@ -827,7 +827,7 @@ class ExtensionServiceTest

const DictionaryValue* dict =

prefs->GetDictionary("extensions.settings");

ASSERT_TRUE(dict != NULL) << msg;

- DictionaryValue* pref = NULL;

+ const DictionaryValue* pref = NULL;

ASSERT_TRUE(dict->GetDictionary(extension_id, &pref)) << msg;

EXPECT_TRUE(pref != NULL) << msg;

bool val;

@@ -840,7 +840,7 @@ class ExtensionServiceTest

const DictionaryValue* dict =

profile_->GetPrefs()->GetDictionary("extensions.settings");

if (dict == NULL) return false;

- DictionaryValue* pref = NULL;

+ const DictionaryValue* pref = NULL;

if (!dict->GetDictionary(extension_id, &pref)) {

return false;

}

@@ -868,7 +868,7 @@ class ExtensionServiceTest

const DictionaryValue* dict =

prefs->GetDictionary("extensions.settings");

ASSERT_TRUE(dict != NULL) << msg;

- DictionaryValue* pref = NULL;

+ const DictionaryValue* pref = NULL;

ASSERT_TRUE(dict->GetDictionary(extension_id, &pref)) << msg;

EXPECT_TRUE(pref != NULL) << msg;

int val;

@@ -889,7 +889,7 @@ class ExtensionServiceTest

const DictionaryValue* dict =

profile_->GetPrefs()->GetDictionary("extensions.settings");

ASSERT_TRUE(dict != NULL) << msg;

- DictionaryValue* pref = NULL;

+ const DictionaryValue* pref = NULL;

std::string manifest_path = extension_id + ".manifest";

ASSERT_TRUE(dict->GetDictionary(manifest_path, &pref)) << msg;

EXPECT_TRUE(pref != NULL) << msg;