chromeos/network/network_sms_handler.cc - Issue 10834004: Correct const accessors in base/values.(h|cc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/network_sms_handler.cc

Issue 10834004: Correct const accessors in base/values.(h|cc) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Reverting webdriver:Command::parameters_ to const Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/network_sms_handler.cc

diff --git a/chromeos/network/network_sms_handler.cc b/chromeos/network/network_sms_handler.cc

index 96f9950e4456ac14787754d3c7d8efd07277c065..58c5ad207f90d1b7b49a45b168acd640eed2984b 100644

--- a/chromeos/network/network_sms_handler.cc

+++ b/chromeos/network/network_sms_handler.cc

@@ -371,7 +371,7 @@ void NetworkSmsHandler::ManagerPropertiesCallback(

LOG(ERROR) << "NetworkSmsHandler: Failed to get manager properties.";

return;

}

- base::Value* value;

+ const base::Value* value;

if (!properties.GetWithoutPathExpansion(flimflam::kDevicesProperty, &value) ||

value->GetType() != base::Value::TYPE_LIST) {

LOG(ERROR) << "NetworkSmsHandler: No list value for: "