chrome/test/webdriver/webdriver_automation.cc - Issue 10834004: Correct const accessors in base/values.(h|cc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/webdriver/webdriver_automation.cc

Issue 10834004: Correct const accessors in base/values.(h|cc) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Reverting webdriver:Command::parameters_ to const Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/webdriver/webdriver_automation.cc

diff --git a/chrome/test/webdriver/webdriver_automation.cc b/chrome/test/webdriver/webdriver_automation.cc

index 5eeb1cb61ee44e0a109e959121cc73d5a7183d08..20fdfae4e199c1aef4e9f297fc2b6ea813ddbc8a 100644

--- a/chrome/test/webdriver/webdriver_automation.cc

+++ b/chrome/test/webdriver/webdriver_automation.cc

@@ -1110,7 +1110,7 @@ void Automation::GetGeolocation(scoped_ptr<DictionaryValue>* geolocation,

}

-void Automation::OverrideGeolocation(DictionaryValue* geolocation,

+void Automation::OverrideGeolocation(const DictionaryValue* geolocation,

Error** error) {

*error = CheckGeolocationSupported();

if (*error)