chrome/installer/util/google_chrome_distribution.cc - Issue 10834004: Correct const accessors in base/values.(h|cc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/google_chrome_distribution.cc

Issue 10834004: Correct const accessors in base/values.(h|cc) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Reverting webdriver:Command::parameters_ to const Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/google_chrome_distribution.cc

diff --git a/chrome/installer/util/google_chrome_distribution.cc b/chrome/installer/util/google_chrome_distribution.cc

index a2f58a5c56de93f46d1ee92e9b969b34527ab53a..80c160f87dbe7a8face4901eb7e3c76728b8bc43 100644

--- a/chrome/installer/util/google_chrome_distribution.cc

+++ b/chrome/installer/util/google_chrome_distribution.cc

@@ -299,7 +299,7 @@ GoogleChromeDistribution::GoogleChromeDistribution()

// see the comment in google_chrome_distribution_dummy.cc

#ifndef _WIN64

bool GoogleChromeDistribution::BuildUninstallMetricsString(

- DictionaryValue* uninstall_metrics_dict, string16* metrics) {

+ const DictionaryValue* uninstall_metrics_dict, string16* metrics) {

DCHECK(NULL != metrics);

bool has_values = false;

@@ -348,7 +348,7 @@ bool GoogleChromeDistribution::ExtractUninstallMetrics(

return false;

}

- DictionaryValue* uninstall_metrics_dict;

+ const DictionaryValue* uninstall_metrics_dict;

if (!root.HasKey(installer::kUninstallMetricsName) ||

!root.GetDictionary(installer::kUninstallMetricsName,

&uninstall_metrics_dict)) {