chrome/browser/plugin_finder.cc - Issue 10834004: Correct const accessors in base/values.(h|cc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugin_finder.cc

Issue 10834004: Correct const accessors in base/values.(h|cc) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Reverting webdriver:Command::parameters_ to const Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/plugin_finder.cc

diff --git a/chrome/browser/plugin_finder.cc b/chrome/browser/plugin_finder.cc

index 0c03e46d11e732dab1576811e8112531ef05c5d0..59a5052950cf60ac6ac7d8b85a1689af4106de23 100644

--- a/chrome/browser/plugin_finder.cc

+++ b/chrome/browser/plugin_finder.cc

@@ -83,7 +83,7 @@ PluginInstaller* PluginFinder::FindPlugin(const std::string& mime_type,

bool success = plugin->GetString("lang", &language_str);

if (language_str != language)

continue;

- ListValue* mime_types = NULL;

+ const ListValue* mime_types = NULL;

plugin->GetList("mime_types", &mime_types);

DCHECK(success);

for (ListValue::const_iterator mime_type_it = mime_types->begin();

@@ -135,7 +135,7 @@ PluginInstaller* PluginFinder::CreateInstaller(

display_url,

GURL(url),

GURL(help_url));

- ListValue* versions = NULL;

+ const ListValue* versions = NULL;

if (plugin_dict->GetList("versions", &versions)) {

for (ListValue::const_iterator it = versions->begin();

it != versions->end(); ++it) {