Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3291)

Unified Diff: chrome/browser/extensions/menu_manager.cc

Issue 10834004: Correct const accessors in base/values.(h|cc) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Reverting webdriver:Command::parameters_ to const Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_web_ui.cc ('k') | chrome/browser/gpu_blacklist.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/menu_manager.cc
diff --git a/chrome/browser/extensions/menu_manager.cc b/chrome/browser/extensions/menu_manager.cc
index e599f3bd238cfba0ce9ff0075d3ee8f225ea2500..92154f981e8a0f222515f477b05df60376a12daa 100644
--- a/chrome/browser/extensions/menu_manager.cc
+++ b/chrome/browser/extensions/menu_manager.cc
@@ -219,7 +219,7 @@ MenuItem* MenuItem::Populate(const std::string& extension_id,
if (!value.GetBoolean(kEnabledKey, &enabled))
return NULL;
ContextList contexts;
- Value* contexts_value = NULL;
+ const Value* contexts_value = NULL;
if (!value.Get(kContextsKey, &contexts_value))
return NULL;
if (!contexts.Populate(*contexts_value))
@@ -248,7 +248,7 @@ bool MenuItem::PopulateURLPatterns(const DictionaryValue& properties,
const char* target_url_patterns_key,
std::string* error) {
if (properties.HasKey(document_url_patterns_key)) {
- ListValue* list = NULL;
+ const ListValue* list = NULL;
if (!properties.GetList(document_url_patterns_key, &list))
return false;
if (!document_url_patterns_.Populate(
@@ -257,7 +257,7 @@ bool MenuItem::PopulateURLPatterns(const DictionaryValue& properties,
}
}
if (properties.HasKey(target_url_patterns_key)) {
- ListValue* list = NULL;
+ const ListValue* list = NULL;
if (!properties.GetList(target_url_patterns_key, &list))
return false;
if (!target_url_patterns_.Populate(
« no previous file with comments | « chrome/browser/extensions/extension_web_ui.cc ('k') | chrome/browser/gpu_blacklist.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698