chrome/browser/extensions/api/proxy/proxy_api_helpers.h - Issue 10834004: Correct const accessors in base/values.(h|cc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/proxy/proxy_api_helpers.h

Issue 10834004: Correct const accessors in base/values.(h|cc) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Reverting webdriver:Command::parameters_ to const Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/proxy/proxy_api_helpers.h

diff --git a/chrome/browser/extensions/api/proxy/proxy_api_helpers.h b/chrome/browser/extensions/api/proxy/proxy_api_helpers.h

index a4b06b2be073f9b09649d3483f552564c69535fc..064b5c2565b57c9b1c23bda06251b48fdf30d678 100644

--- a/chrome/browser/extensions/api/proxy/proxy_api_helpers.h

+++ b/chrome/browser/extensions/api/proxy/proxy_api_helpers.h

@@ -100,7 +100,7 @@ bool GetProxyServer(const base::DictionaryValue* proxy_server,

// Joins a list of URLs (stored as StringValues) in |list| with |joiner|

// to |out|. Returns true if successful and sets |error| otherwise.

-bool JoinUrlList(base::ListValue* list,

+bool JoinUrlList(const base::ListValue* list,

const std::string& joiner,

std::string* out,

std::string* error,