Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4093)

Unified Diff: base/test/trace_event_analyzer.cc

Issue 10834004: Correct const accessors in base/values.(h|cc) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Reverting webdriver:Command::parameters_ to const Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/json/json_writer.cc ('k') | base/test/values_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/trace_event_analyzer.cc
diff --git a/base/test/trace_event_analyzer.cc b/base/test/trace_event_analyzer.cc
index c0d9fae4be6ed04ad93b2c57601ee6ae73929834..ad507252749579784f0b07407d0c70eb905d3a16 100644
--- a/base/test/trace_event_analyzer.cc
+++ b/base/test/trace_event_analyzer.cc
@@ -35,7 +35,7 @@ bool TraceEvent::SetFromJSON(const base::Value* event_value) {
static_cast<const base::DictionaryValue*>(event_value);
std::string phase_str;
- base::DictionaryValue* args = NULL;
+ const base::DictionaryValue* args = NULL;
if (!dictionary->GetString("ph", &phase_str)) {
LOG(ERROR) << "ph is missing from TraceEvent JSON";
@@ -85,7 +85,7 @@ bool TraceEvent::SetFromJSON(const base::Value* event_value) {
bool boolean = false;
int int_num = 0;
double double_num = 0.0;
- Value* value = NULL;
+ const Value* value = NULL;
if (args->GetWithoutPathExpansion(*keyi, &value)) {
if (value->GetAsString(&str))
arg_strings[*keyi] = str;
@@ -957,4 +957,3 @@ size_t CountMatches(const TraceEventVector& events,
}
} // namespace trace_analyzer
-
« no previous file with comments | « base/json/json_writer.cc ('k') | base/test/values_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698