base/json/json_value_converter.h - Issue 10834004: Correct const accessors in base/values.(h|cc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/json/json_value_converter.h

Issue 10834004: Correct const accessors in base/values.(h|cc) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Reverting webdriver:Command::parameters_ to const Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/json/json_value_converter.h

diff --git a/base/json/json_value_converter.h b/base/json/json_value_converter.h

index 2d605e47f61910cc66883c0a1ee17e02bd16a34e..9d3036a429abd2aaf4f949995ee69cb8ac2bd8da 100644

--- a/base/json/json_value_converter.h

+++ b/base/json/json_value_converter.h

@@ -505,7 +505,7 @@ class JSONValueConverter {

for(size_t i = 0; i < fields_.size(); ++i) {

const internal::FieldConverterBase<StructType>* field_converter =

fields_[i];

- base::Value* field = NULL;

+ const base::Value* field = NULL;

if (dictionary_value->Get(field_converter->field_path(), &field)) {

if (!field_converter->ConvertField(*field, output)) {

DVLOG(1) << "failure at field " << field_converter->field_path();

« no previous file with comments | « no previous file | base/json/json_writer.cc » ('j') | no next file with comments »