Correct const accessors in base/values.(h|cc)

chrome/test/webdriver/webdriver_session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/webdriver/webdriver_session.h"
 
 #include <sstream>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 565 matching lines @@
   return error;
 }
 
 Error* Session::SetCookie(const std::string& url,
                           DictionaryValue* cookie_dict) {
   Error* error = NULL;
   RunSessionTask(base::Bind(
       &Automation::SetCookie,
       base::Unretained(automation_.get()),
       url,
       cookie_dict,

[vabr (Chromium), 2012/07/26 20:48:03]

Does this deep-copy cookie_dict, or does it rather only copy the direct data
members (pointers to allocated data) of the object?

       &error));
   return error;
 }
 
 Error* Session::GetViews(std::vector<WebViewInfo>* views) {
   Error* error = NULL;
   RunSessionTask(base::Bind(
       &Automation::GetViews,
       base::Unretained(automation_.get()),
       views,
@@ skipping 770 matching lines @@
 Error* Session::GetGeolocation(scoped_ptr<base::DictionaryValue>* geolocation) {
   Error* error = NULL;
   RunSessionTask(base::Bind(
       &Automation::GetGeolocation,
       base::Unretained(automation_.get()),
       geolocation,
       &error));
   return error;
 }
 
-Error* Session::OverrideGeolocation(base::DictionaryValue* geolocation) {
+Error* Session::OverrideGeolocation(const base::DictionaryValue* geolocation) {
   Error* error = NULL;
   RunSessionTask(base::Bind(
       &Automation::OverrideGeolocation,
       base::Unretained(automation_.get()),
       geolocation,
       &error));
   return error;
 }
 
 const std::string& Session::id() const {
@@ skipping 534 matching lines @@
     capabilities_.local_state->GetWithoutPathExpansion(*iter, &value);
     Error* error = SetPreference(*iter, false /* is_user_pref */,
                                  value->DeepCopy());
     if (error)
       return error;
   }
   return NULL;
 }
 
 }  // namespace webdriver