Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: chrome/test/webdriver/commands/webdriver_command.cc

Issue 10834004: Correct const accessors in base/values.(h|cc) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: One more, Windows-only Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/webdriver/commands/webdriver_command.h" 5 #include "chrome/test/webdriver/commands/webdriver_command.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/memory/singleton.h" 10 #include "base/memory/singleton.h"
11 #include "base/string_util.h" 11 #include "base/string_util.h"
12 #include "base/stringprintf.h" 12 #include "base/stringprintf.h"
13 #include "base/values.h" 13 #include "base/values.h"
14 #include "chrome/test/webdriver/commands/response.h" 14 #include "chrome/test/webdriver/commands/response.h"
15 #include "chrome/test/webdriver/webdriver_error.h" 15 #include "chrome/test/webdriver/webdriver_error.h"
16 #include "chrome/test/webdriver/webdriver_logging.h" 16 #include "chrome/test/webdriver/webdriver_logging.h"
17 #include "chrome/test/webdriver/webdriver_session.h" 17 #include "chrome/test/webdriver/webdriver_session.h"
18 #include "chrome/test/webdriver/webdriver_session_manager.h" 18 #include "chrome/test/webdriver/webdriver_session_manager.h"
19 #include "chrome/test/webdriver/webdriver_util.h" 19 #include "chrome/test/webdriver/webdriver_util.h"
20 20
21 namespace webdriver { 21 namespace webdriver {
22 22
23 WebDriverCommand::WebDriverCommand( 23 WebDriverCommand::WebDriverCommand(
24 const std::vector<std::string>& path_segments, 24 const std::vector<std::string>& path_segments,
25 const DictionaryValue* const parameters) 25 DictionaryValue* const parameters)
26 : Command(path_segments, parameters), session_(NULL) { 26 : Command(path_segments, parameters), session_(NULL) {
27 } 27 }
28 28
29 WebDriverCommand::~WebDriverCommand() {} 29 WebDriverCommand::~WebDriverCommand() {}
30 30
31 bool WebDriverCommand::Init(Response* const response) { 31 bool WebDriverCommand::Init(Response* const response) {
32 // There should be at least 3 path segments to match "/session/$id". 32 // There should be at least 3 path segments to match "/session/$id".
33 session_id_ = GetPathVariable(2); 33 session_id_ = GetPathVariable(2);
34 if (session_id_.length() == 0) { 34 if (session_id_.length() == 0) {
35 response->SetError( 35 response->SetError(
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 "Command finished (%s) with response %s", 82 "Command finished (%s) with response %s",
83 JoinString(path_segments_, '/').c_str(), 83 JoinString(path_segments_, '/').c_str(),
84 JsonStringifyForDisplay(response->GetDictionary()).c_str())); 84 JsonStringifyForDisplay(response->GetDictionary()).c_str()));
85 } 85 }
86 86
87 bool WebDriverCommand::ShouldRunPreAndPostCommandHandlers() { 87 bool WebDriverCommand::ShouldRunPreAndPostCommandHandlers() {
88 return true; 88 return true;
89 } 89 }
90 90
91 } // namespace webdriver 91 } // namespace webdriver
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698