Correct const accessors in base/values.(h|cc)

chrome/test/webdriver/commands/cookie_commands.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/webdriver/commands/cookie_commands.h"
 
 #include <string>
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/string_split.h"
 #include "base/string_util.h"
 #include "base/values.h"
 #include "chrome/test/webdriver/commands/response.h"
 #include "chrome/test/webdriver/webdriver_session.h"
 
 namespace webdriver {
 
 CookieCommand::CookieCommand(const std::vector<std::string>& path_segments,
-                             const DictionaryValue* const parameters)
+                             DictionaryValue* const parameters)
     : WebDriverCommand(path_segments, parameters) {}
 
 CookieCommand::~CookieCommand() {}
 
 bool CookieCommand::DoesDelete() {
   return true;
 }
 
 bool CookieCommand::DoesGet() {
   return true;
@@ skipping 11 matching lines @@
     error = session_->GetCookies(url, &cookies);
   if (error) {
     response->SetError(error);
     return;
   }
   response->SetValue(cookies);
 }
 
 void CookieCommand::ExecutePost(Response* const response) {
   DictionaryValue* cookie_dict;
   if (!GetDictionaryParameter("cookie", &cookie_dict)) {

[vabr (Chromium), 2012/07/26 20:48:03]

Here we get a sub-dictionary cookie_dict from parameters_.

     response->SetError(new Error(
         kBadRequest, "Missing or invalid |cookie| parameter"));
     return;
   }
 
   std::string domain;
   if (cookie_dict->GetString("domain", &domain)) {
     std::vector<std::string> split_domain;
     base::SplitString(domain, ':', &split_domain);
     if (split_domain.size() > 2) {
       response->SetError(new Error(
           kInvalidCookieDomain, "Cookie domain has too many colons"));
       return;
     } else if (split_domain.size() == 2) {
       // Remove the port number.
       cookie_dict->SetString("domain", split_domain[0]);

[vabr (Chromium), 2012/07/26 20:48:03]

Here we modify the sub-dictionary cookie_dict of the supposedly const dictionary
parameters_.

     }
   }
 
   std::string url;
   Error* error = session_->GetURL(&url);
   if (!error)
     error = session_->SetCookie(url, cookie_dict);

[vabr (Chromium), 2012/07/26 20:48:03]

Here we pass cookie_dict to SetCookie, which will post the asynchronous task.

   if (error) {
     response->SetError(error);
     return;
   }
 }
 
 void CookieCommand::ExecuteDelete(Response* const response) {
   std::string url;
   Error* error = session_->GetURL(&url);
   ListValue* unscoped_cookies = NULL;
@@ skipping 22 matching lines @@
     error = session_->DeleteCookie(url, name);
     if (error) {
       response->SetError(error);
       return;
     }
   }
 }
 
 NamedCookieCommand::NamedCookieCommand(
     const std::vector<std::string>& path_segments,
-    const DictionaryValue* const parameters)
+    DictionaryValue* const parameters)
     : WebDriverCommand(path_segments, parameters) {}
 
 NamedCookieCommand::~NamedCookieCommand() {}
 
 bool NamedCookieCommand::Init(Response* const response) {
   if (!WebDriverCommand::Init(response))
     return false;
 
   // There should be at least 5 segments to match
   // /session/:sessionId/cookie/:name
@@ skipping 15 matching lines @@
   Error* error = session_->GetURL(&url);
   if (!error)
     error = session_->DeleteCookie(url, cookie_name_);
   if (error) {
     response->SetError(error);
     return;
   }
 }
 
 }  // namespace webdriver