Correct const accessors in base/values.(h|cc)

content/browser/geolocation/network_location_request.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/geolocation/network_location_request.h"
 
 #include <set>
 #include <string>
 
 #include "base/json/json_reader.h"
@@ skipping 275 matching lines @@
 }
 
 // Numeric values without a decimal point have type integer and IsDouble() will
 // return false. This is convenience function for detecting integer or floating
 // point numeric values. Note that isIntegral() includes boolean values, which
 // is not what we want.
 bool GetAsDouble(const DictionaryValue& object,
                  const std::string& property_name,
                  double* out) {
   DCHECK(out);
-  Value* value = NULL;
+  const Value* value = NULL;
   if (!object.Get(property_name, &value))
     return false;
   int value_as_int;
   DCHECK(value);
   if (value->GetAsInteger(&value_as_int)) {
     *out = value_as_int;
     return true;
   }
   return value->GetAsDouble(out);
 }
@@ skipping 26 matching lines @@
 
   if (!response_value->IsType(Value::TYPE_DICTIONARY)) {
     VLOG(1) << "ParseServerResponse() : Unexpected response type "
             << response_value->GetType();
     return false;
   }
   const DictionaryValue* response_object =
       static_cast<DictionaryValue*>(response_value.get());
 
   // Check the status code.
-  Value* status_value = NULL;
+  const Value* status_value = NULL;
   if (!response_object->Get(kStatusString, &status_value)) {
     VLOG(1) << "ParseServerResponse() : Missing status attribute.";
     // The status attribute is required.
     return false;
   }
   DCHECK(status_value);
 
   if (!status_value->IsType(Value::TYPE_STRING)) {
     VLOG(1) << "ParseServerResponse() : Unexpected status type "
             << status_value->GetType();
     // The status attribute is required to be a string.
     return false;
   }
-  StringValue* status_object = static_cast<StringValue*>(status_value);
+  const StringValue* status_object =
+      static_cast<const StringValue*>(status_value);
 
   std::string status;
   if (!status_object->GetAsString(&status)) {
     VLOG(1) << "ParseServerResponse() : Error parsing the status value.";
     return false;
   }
 
   if (status != kStatusOKString) {
     VLOG(1) << "ParseServerResponse() : Request failed with status "
             << status;
     return false;
   }
 
   // Get the access token, if any.
   response_object->GetString(kAccessTokenString, access_token);
 
   // Get the location
-  Value* location_value = NULL;
+  const Value* location_value = NULL;
   if (!response_object->Get(kLocationString, &location_value)) {
     VLOG(1) << "ParseServerResponse() : Missing location attribute.";
     // GLS returns a response with no location property to represent
     // no fix available; return true to indicate successful parse.
     return true;
   }
   DCHECK(location_value);
 
   if (!location_value->IsType(Value::TYPE_DICTIONARY)) {
     if (!location_value->IsType(Value::TYPE_NULL)) {
       VLOG(1) << "ParseServerResponse() : Unexpected location type "
               << location_value->GetType();
       // If the network provider was unable to provide a position fix, it should
       // return a HTTP 200, with "location" : null. Otherwise it's an error.
       return false;
     }
     return true;  // Successfully parsed response containing no fix.
   }
-  DictionaryValue* location_object =
-      static_cast<DictionaryValue*>(location_value);
+  const DictionaryValue* location_object =
+      static_cast<const DictionaryValue*>(location_value);
 
   // latitude and longitude fields are always required.
   double latitude, longitude;
   if (!GetAsDouble(*location_object, kLatitudeString, &latitude) ||
       !GetAsDouble(*location_object, kLongitudeString, &longitude)) {
     VLOG(1) << "ParseServerResponse() : location lacks lat and/or long.";
     return false;
   }
   // All error paths covered: now start actually modifying postion.
   position->latitude = latitude;
   position->longitude = longitude;
   position->timestamp = timestamp;
 
   // Other fields are optional.
   GetAsDouble(*response_object, kAccuracyString, &position->accuracy);
 
   return true;
 }
 
 }  // namespace