Correct const accessors in base/values.(h|cc)

chrome/test/webdriver/webdriver_session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/webdriver/webdriver_session.h"
 
 #include <sstream>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 558 matching lines @@
   Error* error = NULL;
   RunSessionTask(base::Bind(
       &Automation::DeleteCookie,
       base::Unretained(automation_.get()),
       url,
       cookie_name,
       &error));
   return error;
 }
 
+// Note that when this is called from CookieCommand::ExecutePost then
+// |cookie_dict| is destroyed as soon as the caller finishes. Therefore
+// it is essential that RunSessionTask executes synchronously.
 Error* Session::SetCookie(const std::string& url,
                           DictionaryValue* cookie_dict) {
   Error* error = NULL;
   RunSessionTask(base::Bind(
       &Automation::SetCookie,
       base::Unretained(automation_.get()),
       url,
       cookie_dict,
       &error));
   return error;
@@ skipping 768 matching lines @@
       type == kLocalStorageType ? atoms::REMOVE_LOCAL_STORAGE_ITEM
                                 : atoms::REMOVE_SESSION_STORAGE_ITEM);
   return ExecuteScriptAndParse(
       current_target_,
       js,
       "removeStorageItem",
       CreateListValueFrom(key),
       CreateDirectValueParser(value));
 }
 
-Error* Session::GetGeolocation(scoped_ptr<base::DictionaryValue>* geolocation) {
+Error* Session::GetGeolocation(
+    scoped_ptr<base::DictionaryValue>* geolocation) {
   Error* error = NULL;
   RunSessionTask(base::Bind(
       &Automation::GetGeolocation,
       base::Unretained(automation_.get()),
       geolocation,
       &error));
   return error;
 }
 
-Error* Session::OverrideGeolocation(base::DictionaryValue* geolocation) {
+Error* Session::OverrideGeolocation(const base::DictionaryValue* geolocation) {
   Error* error = NULL;
   RunSessionTask(base::Bind(
       &Automation::OverrideGeolocation,
       base::Unretained(automation_.get()),
       geolocation,
       &error));
   return error;
 }
 
 const std::string& Session::id() const {
@@ skipping 36 matching lines @@
   return capabilities_;
 }
 
 void Session::RunSessionTask(const base::Closure& task) {
   base::WaitableEvent done_event(false, false);
   thread_.message_loop_proxy()->PostTask(FROM_HERE, base::Bind(
       &Session::RunClosureOnSessionThread,
       base::Unretained(this),
       task,
       &done_event));
+  // See SetCookie for why it is essential that we wait here.
   done_event.Wait();
 }
 
 void Session::RunClosureOnSessionThread(const base::Closure& task,
                                         base::WaitableEvent* done_event) {
   task.Run();
   done_event->Signal();
 }
 
 void Session::InitOnSessionThread(const Automation::BrowserOptions& options,
@@ skipping 478 matching lines @@
     capabilities_.local_state->GetWithoutPathExpansion(*iter, &value);
     Error* error = SetPreference(*iter, false /* is_user_pref */,
                                  value->DeepCopy());
     if (error)
       return error;
   }
   return NULL;
 }
 
 }  // namespace webdriver