Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: chrome/browser/plugin_finder_unittest.cc

Issue 10834004: Correct const accessors in base/values.(h|cc) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Reverting webdriver:Command::parameters_ to const Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/plugin_finder.cc ('k') | chrome/browser/policy/configuration_policy_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/plugin_finder.h" 5 #include "chrome/browser/plugin_finder.h"
6 6
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "chrome/browser/plugin_installer.h" 8 #include "chrome/browser/plugin_installer.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 #include "webkit/plugins/npapi/plugin_list.h" 10 #include "webkit/plugins/npapi/plugin_list.h"
(...skipping 15 matching lines...) Expand all
26 EXPECT_TRUE(plugin->GetString("lang", &dummy_str)); 26 EXPECT_TRUE(plugin->GetString("lang", &dummy_str));
27 if (plugin->HasKey("url")) 27 if (plugin->HasKey("url"))
28 EXPECT_TRUE(plugin->GetString("url", &dummy_str)); 28 EXPECT_TRUE(plugin->GetString("url", &dummy_str));
29 EXPECT_TRUE(plugin->GetString("name", &dummy_str)); 29 EXPECT_TRUE(plugin->GetString("name", &dummy_str));
30 if (plugin->HasKey("help_url")) 30 if (plugin->HasKey("help_url"))
31 EXPECT_TRUE(plugin->GetString("help_url", &dummy_str)); 31 EXPECT_TRUE(plugin->GetString("help_url", &dummy_str));
32 if (plugin->HasKey("displayurl")) 32 if (plugin->HasKey("displayurl"))
33 EXPECT_TRUE(plugin->GetBoolean("displayurl", &dummy_bool)); 33 EXPECT_TRUE(plugin->GetBoolean("displayurl", &dummy_bool));
34 if (plugin->HasKey("requires_authorization")) 34 if (plugin->HasKey("requires_authorization"))
35 EXPECT_TRUE(plugin->GetBoolean("requires_authorization", &dummy_bool)); 35 EXPECT_TRUE(plugin->GetBoolean("requires_authorization", &dummy_bool));
36 ListValue* mime_types = NULL; 36 const ListValue* mime_types = NULL;
37 ASSERT_TRUE(plugin->GetList("mime_types", &mime_types)); 37 ASSERT_TRUE(plugin->GetList("mime_types", &mime_types));
38 for (ListValue::const_iterator mime_type_it = mime_types->begin(); 38 for (ListValue::const_iterator mime_type_it = mime_types->begin();
39 mime_type_it != mime_types->end(); ++mime_type_it) { 39 mime_type_it != mime_types->end(); ++mime_type_it) {
40 EXPECT_TRUE((*mime_type_it)->GetAsString(&dummy_str)); 40 EXPECT_TRUE((*mime_type_it)->GetAsString(&dummy_str));
41 } 41 }
42 ListValue* versions = NULL; 42 const ListValue* versions = NULL;
43 if (!plugin->GetList("versions", &versions)) 43 if (!plugin->GetList("versions", &versions))
44 continue; 44 continue;
45 45
46 for (ListValue::const_iterator it = versions->begin(); 46 for (ListValue::const_iterator it = versions->begin();
47 it != versions->end(); ++it) { 47 it != versions->end(); ++it) {
48 DictionaryValue* version_dict = NULL; 48 DictionaryValue* version_dict = NULL;
49 ASSERT_TRUE((*it)->GetAsDictionary(&version_dict)); 49 ASSERT_TRUE((*it)->GetAsDictionary(&version_dict));
50 EXPECT_TRUE(version_dict->GetString("version", &dummy_str)); 50 EXPECT_TRUE(version_dict->GetString("version", &dummy_str));
51 std::string status_str; 51 std::string status_str;
52 EXPECT_TRUE(version_dict->GetString("status", &status_str)); 52 EXPECT_TRUE(version_dict->GetString("status", &status_str));
53 PluginInstaller::SecurityStatus status = 53 PluginInstaller::SecurityStatus status =
54 PluginInstaller::SECURITY_STATUS_UP_TO_DATE; 54 PluginInstaller::SECURITY_STATUS_UP_TO_DATE;
55 EXPECT_TRUE(PluginInstaller::ParseSecurityStatus(status_str, &status)) 55 EXPECT_TRUE(PluginInstaller::ParseSecurityStatus(status_str, &status))
56 << "Invalid security status \"" << status_str << "\""; 56 << "Invalid security status \"" << status_str << "\"";
57 } 57 }
58 } 58 }
59 } 59 }
OLDNEW
« no previous file with comments | « chrome/browser/plugin_finder.cc ('k') | chrome/browser/policy/configuration_policy_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698