Issue 10833071: Renaming the 'keybinding' permission to 'commands'.

Issue 10833071: Renaming the 'keybinding' permission to 'commands'. (Closed)

Created:
8 years, 4 months ago by Finnur

Modified:
8 years, 4 months ago

Reviewers:
Yoyo Zhou, sky

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Renaming the 'keybinding' permission to 'commands'. BUG=135562 TEST=Covered by automated tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149147

Patch Set 3 : #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -130 lines)			Patch
M	chrome/browser/extensions/api/commands/command_service.cc	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/extensions/browser_event_router.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/api/_permission_features.json	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
A +	chrome/common/extensions/api/experimental_commands.json	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/common/extensions/api/experimental_keybinding.json	View	1	1 chunk	+0 lines, -22 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/docs/js/api_page_generator.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/common/extensions/docs/static/experimental.commands.html	View		3 chunks	+5 lines, -5 lines	0 comments	Download
D	chrome/common/extensions/docs/static/experimental.keybinding.html	View	1	1 chunk	+0 lines, -78 lines	0 comments	Download
M	chrome/common/extensions/permissions/api_permission.h	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/permissions/api_permission.cc	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/permissions/permission_set_unittest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions_api_resources.grd	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/pref_names.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/pref_names.cc	View	1	1 chunk	+2 lines, -2 lines	1 comment	Download
M	chrome/test/data/extensions/api_test/keybinding/basics/background.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/keybinding/basics/manifest.json	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/keybinding/conflicting/background.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/keybinding/conflicting/manifest.json	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/keybinding/page_action/manifest.json	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yoyo Zhou

LGTM http://codereview.chromium.org/10833071/diff/7002/chrome/common/pref_names.cc File chrome/common/pref_names.cc (right): http://codereview.chromium.org/10833071/diff/7002/chrome/common/pref_names.cc#newcode805 chrome/common/pref_names.cc:805: // Dictionary pref that tracks which commands belongs ...

8 years, 4 months ago (2012-07-31 08:02:27 UTC) #2

Finnur

8 years, 4 months ago (2012-07-31 08:12:56 UTC) #3

Scott, maybe I'm just being pedantic, but I need OWNERS approval for a variable
rename for chrome/common/pref_names.[cc|h]

Since this is such a small remaining nit I think I'm going to land this change
without it, since I'm 9 hrs ahead of you in timezones and this is blocking other
work I need to do.

Expand Messages | Collapse Messages