Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: content/renderer/media/peer_connection_handler_jsep_unittest.cc

Issue 10833061: Rolling libjingle revison r163. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/peer_connection_handler_jsep_unittest.cc
===================================================================
--- content/renderer/media/peer_connection_handler_jsep_unittest.cc (revision 148953)
+++ content/renderer/media/peer_connection_handler_jsep_unittest.cc (working copy)
@@ -210,11 +210,11 @@
// Process ICE message.
WebKit::WebICECandidateDescriptor candidate;
- WebKit::WebString label = "test label";
+ WebKit::WebString label = "0";
sdp = "test sdp";
candidate.initialize(label, sdp);
EXPECT_TRUE(pc_handler_->processIceMessage(candidate));
- EXPECT_EQ(UTF16ToUTF8(label), mock_peer_connection_->ice_label());
+ EXPECT_EQ(UTF16ToUTF8(label), mock_peer_connection_->sdp_mid());
Ronghua Wu (Left Chromium) 2012/07/30 18:09:10 will them equal?
Mallinath (Gone from Chromium) 2012/07/30 18:42:08 Removed label and using sdp_mid as per impl.
EXPECT_EQ(UTF16ToUTF8(sdp), mock_peer_connection_->ice_sdp());
// Add stream.
@@ -260,11 +260,13 @@
mock_client_->ready_state());
// On ICE candidate.
- std::string candidate_label = "test label";
+ std::string candidate_label = "0";
std::string candidate_sdp = "test sdp";
+ int sdp_mline_index = 0;
scoped_ptr<webrtc::IceCandidateInterface> native_candidate(
mock_dependency_factory_->CreateIceCandidate(candidate_label,
- candidate_sdp));
+ sdp_mline_index,
+ candidate_sdp));
pc_handler_->OnIceCandidate(native_candidate.get());
EXPECT_EQ(candidate_label, mock_client_->candidate_label());
EXPECT_EQ(candidate_sdp, mock_client_->candidate_sdp());

Powered by Google App Engine
This is Rietveld 408576698