chrome/browser/extensions/webstore_installer.h - Issue 10833058: Make DownloadItem derive SupportsUserData instead of re-implementing it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_installer.h

Issue 10833058: Make DownloadItem derive SupportsUserData instead of re-implementing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/gdata/gdata_download_observer.cc ('K') | « chrome/browser/download/download_completion_blocker.h ('k') | chrome/browser/extensions/webstore_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/webstore_installer.h

diff --git a/chrome/browser/extensions/webstore_installer.h b/chrome/browser/extensions/webstore_installer.h

index aaf95fbc18bfa620af3e3b0a938b5e5ef99e942c..150ae5138b932af96ca2b31b0832446fb581e78c 100644

--- a/chrome/browser/extensions/webstore_installer.h

+++ b/chrome/browser/extensions/webstore_installer.h

@@ -57,7 +57,7 @@ class WebstoreInstaller :public content::NotificationObserver,

// be skipped or modified. If one of these is present, it means that a CRX

// download was initiated by WebstoreInstaller. The Approval instance should

// be checked further for additional details.

- struct Approval : public content::DownloadItem::ExternalData {

+ struct Approval : public base::SupportsUserData::Data {

static scoped_ptr<Approval> CreateWithInstallPrompt(Profile* profile);

static scoped_ptr<Approval> CreateWithNoInstallPrompt(

Profile* profile,