Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3524)

Unified Diff: chrome/browser/extensions/extension_info_map.cc

Issue 10833014: Coverity fixlet. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_info_map.cc
diff --git a/chrome/browser/extensions/extension_info_map.cc b/chrome/browser/extensions/extension_info_map.cc
index 39357c11e1ec20ed293ebd9599940c93253c61e4..afe20fa059e660ce91166dd8f93a011a99b28646 100644
--- a/chrome/browser/extensions/extension_info_map.cc
+++ b/chrome/browser/extensions/extension_info_map.cc
@@ -127,7 +127,9 @@ bool ExtensionInfoMap::SecurityOriginHasAPIPermission(
extensions::APIPermission::ID permission) const {
if (origin.SchemeIs(chrome::kExtensionScheme)) {
const std::string& id = origin.host();
- return extensions_.GetByID(id)->HasAPIPermission(permission) &&
+ const Extension* extension = extensions_.GetByID(id);
+ DCHECK(extension != NULL);
asargent_no_longer_on_chrome 2012/07/25 19:22:15 It might be better to make this a CHECK instead of
Danh Nguyen 2012/07/25 20:25:03 Done.
+ return extension->HasAPIPermission(permission) &&
process_map_.Contains(id, process_id);
}

Powered by Google App Engine
This is Rietveld 408576698