Gentle start with removing explicit interfaces

runtime/vm/class_finalizer.cc

Index: runtime/vm/class_finalizer.cc
===================================================================
--- runtime/vm/class_finalizer.cc	(revision 11079)
+++ runtime/vm/class_finalizer.cc	(working copy)
@@ -1344,11 +1344,11 @@
     // represent a function type, therefore implementing the Function interface.
     if (!cls_belongs_to_core_lib) {
       if (interface.IsBoolInterface() ||
-          interface.IsNumberInterface() ||
+          interface.IsNumber() ||

[regis, 2012/08/21 19:13:22]

Besides type testers, we also have class testers and handle tester:
IsObjectType(), IsObjectClass(), and IsObject(); IsDynamicType() and
IsDynamicClass() (no handle tester for Dynamic).

With your rename, I guess all flavors would have the same name. The code would
be harder to read, since you would need  to known if the receiver is a class, a
type, or a handle:
handle.IsString()  VM class String or one of its subclass?
cls.IsString()  cls == String?   
type.IsString()  dart String type?

[hausner, 2012/08/23 00:25:06]

Agree. Changing to IsFunctionType() and IsNumberType() as you suggest.

On 2012/08/21 19:13:22, regis wrote:

           interface.IsIntInterface() ||
           interface.IsDoubleInterface() ||
           interface.IsStringInterface() ||
-          (interface.IsFunctionInterface() && !cls.IsSignatureClass()) ||
+          (interface.IsFunction() && !cls.IsSignatureClass()) ||
           interface.IsDynamicType()) {
         const Script& script = Script::Handle(cls.script());
         ReportError(script, cls.token_pos(),