Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: runtime/vm/raw_object_snapshot.cc

Issue 10832401: Gentle start with removing explicit interfaces (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/raw_object_snapshot.cc
===================================================================
--- runtime/vm/raw_object_snapshot.cc (revision 11192)
+++ runtime/vm/raw_object_snapshot.cc (working copy)
@@ -42,7 +42,7 @@
cls = reader->NewClass(class_id, is_signature_class);
} else {
if (class_id < kNumPredefinedCids) {
- ASSERT((class_id >= kInstanceCid) && (class_id <= kWeakPropertyCid));
+ ASSERT((class_id >= kInstanceCid) && (class_id <= kDartFunctionCid));
cls = reader->isolate()->class_table()->At(class_id);
} else {
if (is_signature_class) {
@@ -53,7 +53,6 @@
}
}
reader->AddBackRef(object_id, &cls, kIsDeserialized);
-
regis 2012/08/23 03:53:10 Blank line removed by accident? Other functions ha
hausner 2012/08/23 18:34:10 Blankness restored to former glory.
// Set the object tags.
cls.set_tags(tags);
@@ -185,7 +184,6 @@
intptr_t tags,
Snapshot::Kind kind) {
ASSERT(reader != NULL);
-
regis 2012/08/23 03:53:10 ditto
hausner 2012/08/23 18:34:10 Done.
// Allocate parameterized type object.
Type& parameterized_type = Type::ZoneHandle(
reader->isolate(), NEW_OBJECT(Type));
@@ -1968,6 +1966,22 @@
#undef BYTEARRAY_TYPE_LIST
+RawDartFunction* DartFunction::ReadFrom(SnapshotReader* reader,
+ intptr_t object_id,
+ intptr_t tags,
+ Snapshot::Kind kind) {
+ UNIMPLEMENTED();
regis 2012/08/23 03:53:10 Better: UNREACHABLE(); // DartFunction is an abst
hausner 2012/08/23 18:34:10 Done.
+ return DartFunction::null();
+}
+
+
+void RawDartFunction::WriteTo(SnapshotWriter* writer,
+ intptr_t object_id,
+ Snapshot::Kind kind) {
+ UNIMPLEMENTED();
regis 2012/08/23 03:53:10 ditto
hausner 2012/08/23 18:34:10 Done.
+}
+
+
RawClosure* Closure::ReadFrom(SnapshotReader* reader,
intptr_t object_id,
intptr_t tags,

Powered by Google App Engine
This is Rietveld 408576698