Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 10832369: Disable two third-party clang warnings on linux. (Closed)

Created:
8 years, 4 months ago by Nico
Modified:
8 years, 4 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, brettw-cc_chromium.org, hans
Visibility:
Public.

Description

Disable two third-party clang warnings on linux. BUG=138571 Landed as part of http://codereview.chromium.org/10827405/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M base/allocator/allocator.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/libxml/libxml.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
8 years, 4 months ago (2012-08-17 16:49:53 UTC) #1
willchan no longer on Chromium
8 years, 4 months ago (2012-08-17 16:54:21 UTC) #2
lgtm


On Fri, Aug 17, 2012 at 9:49 AM, <thakis@chromium.org> wrote:

> Reviewers: willchan,
>
> Description:
> Disable two third-party clang warnings on linux.
>
> BUG=138571
>
>
> Please review this at
https://chromiumcodereview.**appspot.com/10832369/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M base/allocator/allocator.gyp
>   M third_party/libxml/libxml.gyp
>
>
> Index: base/allocator/allocator.gyp
> diff --git a/base/allocator/allocator.gyp b/base/allocator/allocator.gyp
> index e2c8ac0faeb383fd96b138b1f99b23**c830ab21bb..**
> 8bed6da428c3997b82b96259cea8de**f6359278a3 100644
> --- a/base/allocator/allocator.gyp
> +++ b/base/allocator/allocator.gyp
> @@ -432,6 +432,11 @@
>              'NO_HEAP_CHECK',
>            ],
>          }],
> +        [ 'clang==1', {
> +          'cflags': [
> +            '-Wno-non-literal-null-**conversion',
> +          ],
> +        }],
>        ],
>      },
>      {
> Index: third_party/libxml/libxml.gyp
> diff --git a/third_party/libxml/libxml.**gyp b/third_party/libxml/libxml.*
> *gyp
> index a180ee6e671d0b18b81e796d42d5e0**b32a79a220..**
> ec572bd5384a04585ee77a1db56d4b**b03d85b823 100644
> --- a/third_party/libxml/libxml.**gyp
> +++ b/third_party/libxml/libxml.**gyp
> @@ -247,6 +247,9 @@
>                'cflags': [
>                  '-Wno-pointer-sign',
>                  '-Wno-empty-body',
> +
> +                # See http://crbug.com/138571#c8
> +                '-Wno-ignored-attributes',
>                ],
>              }],
>            ],
>
>
>

Powered by Google App Engine
This is Rietveld 408576698