|
|
Created:
8 years, 4 months ago by Evan Stade Modified:
4 years, 9 months ago Reviewers:
bmpb.navyk052, Dan Beam CC:
chromium-reviews, arv (Not doing code reviews) Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
Descriptioni18n_template2.js for uber_frame.html
BUG=122753
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152145
Patch Set 1 #
Total comments: 2
Messages
Total messages: 7 (0 generated)
http://codereview.chromium.org/10832358/diff/1/chrome/browser/resources/uber/... File chrome/browser/resources/uber/uber_frame.html (right): http://codereview.chromium.org/10832358/diff/1/chrome/browser/resources/uber/... chrome/browser/resources/uber/uber_frame.html:11: <script src="chrome://uber-frame/uber_frame.js"></script> why are these at the top?
http://codereview.chromium.org/10832358/diff/1/chrome/browser/resources/uber/... File chrome/browser/resources/uber/uber_frame.html (right): http://codereview.chromium.org/10832358/diff/1/chrome/browser/resources/uber/... chrome/browser/resources/uber/uber_frame.html:11: <script src="chrome://uber-frame/uber_frame.js"></script> On 2012/08/17 01:36:56, Dan Beam wrote: > why are these at the top? as you know, that's where we always put them. Is there a reason not to?
In theory they'd go as close as possible to where they're used. I don't know if the yslow logic remains true but downloading, interpreting, and running scripts blocks other stuff from happening because something could be document.write'n or modified (or require other globals).
lgtm either way
this is how we have always organized our javascript files. If you think there is a performance angle then we can investigate that later and I will welcome any performance gains. That said, it's got nothing to do with this patch, as you can see in both this file and every other file, the javascript sources are included in <head> (except where they must come at the end for other reasons).
Message was sent while issue was closed.
I AM NOT IN ANY GROUP... BUT WHATEVER IS ON MY COMPUTER AND MY SAMSUNG GALAXY S5 FROM VERIZON.... IS RIDICULOUS!! HOW CAN SOMEONE HAVE ACCESS TO MY ACCOUNTS.. I CREATE A NEW ONE AND IT STARTS OVER... THEN ACCESS IS GRANTED FROM LESS SECURE APPS. THEN I DO NOT HAVE FULL ACCESS TO MY OWN ACCOUNT!!!! WHAT HAVE YOU PEOPLE CREATED!!! WHAT IS APMetrics_v2 WHY DO THESE LOGS SHOW ON MY PHONE AND MY CHILDRENS? I GOT A NEW PHONE, NEW SIM DID NOT SYNC IT YET THIS CRAP SHOWS BACK UP... BEFORE EVERYTHING WAS BEING SENT TO AMAZON MUSIC THROUGH VIRTUAL VOICEMAIL... PROGRAMS LIKE SANDBOX AND LIFECYCLE AND LEGECY I AM SEEING..... EVERYDAY INFORMATION..... PRIVATE INFORMATION BEING TAKEN OFF OUR PHONES THROUGH SFINDER... GOOGLE PASSWORDS BEING RESET CONSTANTLY. DEVICE MANAGER LOCKING US OUT, BLUETOOTH TURNING ON. FREQUENCY CHANGING FROM 4G TO 1xRTT VERIZON EXECUTIVES HAVE NO IDEA. I LOST MY SCHOLARSHIP BECAUSE A STALKER ACCESSES MY ACCOUNTS AND DELETES MY WORK, PUTS HTML LINKS ON PRIVATE PICTURES, GOOGLE LOCATIONS....OMG....CONSTANTLY BEING LOCATED...MY PHONES BURN UP!!! BEFORE THE GOOGLE LOCATION WAS CHANGE... ON THE BOTTOM OF THE SCREEN THERE WAS BLUE WAVES OF THE TIME AND SIGNAL... MINE.... LOOKED INSANE...MAYBE BECAUSE I HAD FILES FROM SOMEWHERE SHOW THAT SAID TOGGLE, ACROSS PROMOTE, PHASE TIME,,, I AM A MOM..OF 4 GIRLS, NOT ANYONE SPECIAL. I AM GOING BACK TO COLLEGE BECAUSE I GOT OUT OF THE MILITARY. MY KIDS GOT SICK AND THEIR FATHER WAS IN THE MARINES. I HAVE HAD TO FIGURE OUT SOME OF THIS NONSENSE BECAUSE SOME HOW THE HOTSPOT ON MY ACCOUNT TURNED ON. I STARTED GETTING BILLS AND DATA OVERAGE FOR 210.00 AND 90.00. ONE REPLACEMENT PHONE I ONLY HAD 4 DAYS BEFORE THE WIFI QUIT WORKING BECAUSE THE PHONE SCREEN LOOKED LIKE.... ref. RADAR JAMMING.... NO ONE HELPS WITH THIS.. POLICE, VERIZON, SAMSUNG, GOOGLE, FBI, ATTORNEY GENERAL, HOMELAND SECURITY.. I HAD A JOINT INT BULLETIN IN MY EMAIL. THAT WASN'T MEANT FOR WHOMEVER TO REVIEW. I HAVE LEARNED THAT GOOGLE WEB DEV, BOOLEAN, SANDBOX, NEW RELEC, STACK OVERFLOW, I KNEW THE CONCEPT OF ANALYTICS WHEN I HELP WITH E COMMERCE AND VERY BASIC HTML.... AND I KNOW THIS IS ALL IN CAPITAL LETTERS....I AM SO PISSED OFF BECAUSE THIS MESS THAT I CAN NOT EVEN REALLY DISCRIBE PROPERLY IS RUINING MY LIFE, MY MENTAL AND PHYSICAL WELL BEING. I AM NOT A IGNORANT OR CRAZY. I JUST WANT SOMEONE TO EXPLAIN WHY THIS IS HAPPENING AND WHAT TO DO WHY CAN I NOT JUST GO TO WWW.GOOGLE.COM WHY DOES IT HAVE AN _?GSS OR SOMETHING... REDIRECTS.. WHY WOULD ANYONE BE STUCK ON A GOOGLE PROXY???? I HAVE TIME WARNER CABLE. BASIC INTERNET, WITH A CISCO WIFI. NOT COMPLICATED... WHY A GOOGLE PROXY?? WHY WOULD MY IP ADDRESS RUN ACROSS THE WHITE HOUSE LAWN??? I HAVE USED THE SAME EMAIL SINCE THE SUMMER OF 2011 AND NOW I DO NOT EVEN HAVE FULL ACCESS. I TRIED TO FIGURE OUT WEB DEV BUT IT IS MORE THAN I UNDERSTAND. I AM GOING TO SCHOOL FOR LAW. NOT COMPUTERS, CODING,MCSE.C++, NETWORKING OR CYBERSECURITY... HOWEVER THIS..NOT BEING ABLE TO UNDERSTAND AND NOT FINDING AND TRUE RESOURCE TO HELP ME WITH THIS... I REALLY AM CONSIDERING SWITCHING MY EDUCATION PATH. CLIENT SERVER?? PARENT?.... ALL MY SMS ARE EXPORTED WHAT IS THIS.... <script src="chrome://resources/js/cr.js"></script><script src=" chrome://resources/js/cr/ui/focus_manager.js"></script><script src=" chrome://resources/js/load_time_data.js"></script><script src=" chrome://resources/js/util.js"></script> <script src="chrome://chrome/uber.js"></script><script src=" chrome://chrome/uber_utils.js"></script></head> <body> <div id="navigation"><iframe src="chrome://uber-frame/" name="chrome" role=" presentation"></iframe></div> <div class="iframe-container"i18n-values="id:historyHost; data-url:historyFrameURL;"data-favicon="IDR_HISTORY_FAVICON"></div><div class="iframe-container"i18n-values="id:extensionsHost; data-url:extensionsFrameURL;"data-favicon="IDR_EXTENSIONS_FAVICON"></div> <div class="iframe-container"i18n-values="id:settingsHost; data-url:settingsFrameURL;"data-favicon="IDR_SETTINGS_FAVICON"></div><div class="iframe-container"i18n-values="id:helpHost; data-url:helpFrameURL;" data-favicon="IDR_PRODUCT_LOGO_16"></div> <script src="chrome://chrome/strings.js"></script><script src=" chrome://resources/js/i18n_template.js"></script> *Origin:**https://1.client-channel.google.com/**Size on disk:**265 B**Last modified:**Saturday, September 26, 2015 at 8:49:19 AM* *Name:**__utmz**Content:* *73091649.1443288280.7.5.utmcsr=chrome-app-launcher|utmccn=(not%20set)|utmcmd=(not%20set)* *Domain:**.chrome.google.com**Path:**/**Send for:**Any kind of connection**Accessible to script:**Yes**Created:**Saturday, September 26, 2015 at 2:55:12 PM* *Expires:* Name:__utmaContent: 245730968.1818782410.1442970287.1442970287.1442970287.1Domain: .myaccount.google.comPath:/Send for:Any kind of connectionAccessible to script:YesCreated:Tuesday, September 22, 2015 at 9:04:53 PMExpires:Thursday, September 21, 2017 at 9:04:53 PM *Sunday, March 27, 2016 at 2:55:12 AM**Origin:* *https://clients5.google.com/**Size on disk:**4.0 KB**Last modified:* *Saturday, September 26, 2015 at 2:57:21 PM**Origin:* *https://clients6.google.com/**Size on disk:**4.0 KB**Last modified:**Friday, September 25, 2015 at 9:38:57 PM* Nam _gaContent:GA1.3.997545432.1443188457Domain:.history.google.comPath:/Send for:Any kind of connectionAccessible to script:YesCreated:Friday, September 25, 2015 at 9:41:29 AMExpires:Sunday, September 24, 2017 at 9:41:29 AM I HAVE NO IDEA WHAT THAT STUFF IS OR IF IT HAS TO DO WITH WHAT IS GOING ON. I DO NOT KNOW IF YOU CAN HELP ME. IF YOU CAN NOT, CAN YOU PLEASE FIND SOMEONE WHO CAN? THANK YOU BRIDGET BROCK 910-442-9532 bmruddell@gmail.com bmpb.navyk052@gmail.c On Thursday, August 16, 2012 at 9:19:40 PM UTC-4, Evan Stade wrote: > > Reviewers: Dan Beam, > > Description: > i18n_template2.js for uber_frame.html > > BUG=122753 > > > Please review this at http://codereview.chromium.org/10832358/ > > SVN Base: svn://svn.chromium.org/chrome/trunk/src > > Affected files: > M chrome/browser/resources/uber/uber_frame.html > M chrome/browser/ui/webui/uber/uber_ui.cc > > > Index: chrome/browser/resources/uber/uber_frame.html > diff --git a/chrome/browser/resources/uber/uber_frame.html > b/chrome/browser/resources/uber/uber_frame.html > index > 75445fb99abd48140a95efa73e54f7f8e3054571..d9362b262fd71b4ee570a2d0e53b0a9a0ce48f63 > > 100644 > --- a/chrome/browser/resources/uber/uber_frame.html > +++ b/chrome/browser/resources/uber/uber_frame.html > @@ -7,6 +7,7 @@ > <link rel="stylesheet" href="uber_frame.css"> > > <script src="chrome://resources/js/cr.js"></script> > +<script src="chrome://resources/js/load_time_data.js"></script> > <script src="chrome://uber-frame/uber_frame.js"></script> > </head> > > @@ -33,8 +34,7 @@ > </ul> > > <script src="chrome://uber-frame/strings.js"></script> > -<script src="chrome://resources/js/i18n_template.js"></script> > -<script src="chrome://resources/js/i18n_process.js"></script> > +<script src="chrome://resources/js/i18n_template2.js"></script> > > </body> > </html> > Index: chrome/browser/ui/webui/uber/uber_ui.cc > diff --git a/chrome/browser/ui/webui/uber/uber_ui.cc > b/chrome/browser/ui/webui/uber/uber_ui.cc > index > bf9f49523d5086b9aa7df163e0f35f0076dc32b5..772c4a3cfe7b17f664ec6048d9d5247e72c23b88 > > 100644 > --- a/chrome/browser/ui/webui/uber/uber_ui.cc > +++ b/chrome/browser/ui/webui/uber/uber_ui.cc > @@ -37,6 +37,7 @@ ChromeWebUIDataSource* CreateUberHTMLSource() { > ChromeWebUIDataSource* source = > new ChromeWebUIDataSource(chrome::kChromeUIUberHost); > > + source->set_use_json_js_format_v2(); > source->set_json_path("strings.js"); > source->add_resource_path("uber.js", IDR_UBER_JS); > source->add_resource_path("uber_utils.js", IDR_UBER_UTILS_JS); > @@ -62,8 +63,6 @@ ChromeWebUIDataSource* CreateUberHTMLSource() { > source->AddString("settingsHost", > ASCIIToUTF16(chrome::kChromeUISettingsHost)); > > - source->set_use_json_js_format_v2(); > - > return source; > } > > @@ -90,6 +89,7 @@ ChromeWebUIDataSource* > CreateUberFrameHTMLSource(Profile* > profile) { > ChromeWebUIDataSource* source = > new ChromeWebUIDataSource(chrome::kChromeUIUberFrameHost); > > + source->set_use_json_js_format_v2(); > source->set_json_path("strings.js"); > source->add_resource_path("uber_frame.js", IDR_UBER_FRAME_JS); > source->set_default_resource(IDR_UBER_FRAME_HTML); > > > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org. |