Platform app context menu items should not be grouped into a submenu.

Platform app context menu items should not be grouped into a submenu.

BUG=141898
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153585

[Mihai Parparita -not on Chrome, 2012-08-16 19:58:02]

http://codereview.chromium.org/10832349/diff/1/chrome/browser/extensions/plat...
File chrome/browser/extensions/platform_app_browsertest.cc (right):

http://codereview.chromium.org/10832349/diff/1/chrome/browser/extensions/plat...
chrome/browser/extensions/platform_app_browsertest.cc:109:
LoadAndLaunchPlatformApp("context_menu2");
I think you missed adding the new test app to the CL.

On the other hand, I don't think it's worth separating this test from
AppWithContextMenu, might as well make that test just have two custom menu
items.

http://codereview.chromium.org/10832349/diff/1/chrome/browser/extensions/plat...
chrome/browser/extensions/platform_app_browsertest.cc:125:
ASSERT_TRUE(menu->HasCommandWithId(IDC_EXTENSIONS_CONTEXT_CUSTOM_FIRST+1));
Add a space before and after the + sign (see
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Horizo...).

[Marijn Kruisselbrink, 2012-08-16 20:23:44]

Okay, I changed the existing test to have two items instead of one

[Mihai Parparita -not on Chrome, 2012-08-16 23:23:09]

LGTM

[commit-bot: I haz the power, 2012-08-16 23:33:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mek@chromium.org/10832349/4001

[commit-bot: I haz the power, 2012-08-16 23:33:56]

Failed to apply patch for
chrome/test/data/extensions/platform_apps/context_menu/test.js:
While running patch -p1 --forward --force;
patching file chrome/test/data/extensions/platform_apps/context_menu/test.js
Hunk #1 FAILED at 3.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/test/data/extensions/platform_apps/context_menu/test.js.rej

[commit-bot: I haz the power, 2012-08-16 23:50:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mek@chromium.org/10832349/1005

[commit-bot: I haz the power, 2012-08-16 23:50:08]

Presubmit check for 10832349-1005 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/tab_contents

[Mihai Parparita -not on Chrome, 2012-08-17 01:05:27]

Brett: can you given an OWNERS LGTM for
the chrome/browser/tab_contents/render_view_context_menu.cc changes?

(Marijn: Brett gets cc-ed on lots of reviews, it's best to point out to him
what you need from him)

Thanks,
Mihai

[brettw, 2012-08-27 19:17:34]

lgtm

[commit-bot: I haz the power, 2012-08-27 19:25:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mek@chromium.org/10832349/1005

[commit-bot: I haz the power, 2012-08-27 23:48:07]

Change committed as 153585