Tab value for context menu onclick event should be optional.

chrome/browser/extensions/menu_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/menu_manager.h"
 
 #include <algorithm>
 
 #include "base/json/json_writer.h"
 #include "base/logging.h"
@@ skipping 599 matching lines @@
   AddURLProperty(properties, "frameUrl", params.frame_url);
 
   if (params.selection_text.length() > 0)
     properties->SetString("selectionText", params.selection_text);
 
   properties->SetBoolean("editable", params.is_editable);
 
   args->Append(properties);
 
   // Add the tab info to the argument list.
+  // No tab info in a platform app

[Mihai Parparita -not on Chrome, 2012/08/16 19:52:42]

Nit: Add period at the end of sentences.

   // Note: web_contents only NULL in unit tests :(

[Mihai Parparita -not on Chrome, 2012/08/16 19:52:42]

Nit: move this comment down one line to be just above the "if (web_contents)"
check, since that's what it's about.

-  if (web_contents)
-    args->Append(ExtensionTabUtil::CreateTabValue(web_contents));
-  else
-    args->Append(new DictionaryValue());
+  if (!extension || !extension->is_platform_app()) {
+    if (web_contents)
+      args->Append(ExtensionTabUtil::CreateTabValue(web_contents));
+    else
+      args->Append(new DictionaryValue());
+  }
 
   if (item->type() == MenuItem::CHECKBOX ||
       item->type() == MenuItem::RADIO) {
     bool was_checked = item->checked();
     properties->SetBoolean("wasChecked", was_checked);
 
     // RADIO items always get set to true when you click on them, but CHECKBOX
     // items get their state toggled.
     bool checked =
         (item->type() == MenuItem::RADIO) ? true : !was_checked;
@@ skipping 180 matching lines @@
       if (uid < other.uid)
         return true;
       if (uid == other.uid)
         return string_uid < other.string_uid;
     }
   }
   return false;
 }
 
 }  // namespace extensions