Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 10832338: Check for Google with GetEngineType in SearchProvider. (Closed)

Created:
8 years, 4 months ago by msw
Modified:
8 years, 4 months ago
CC:
chromium-reviews, James Su
Visibility:
Public.

Description

Check for Google with GetEngineType in SearchProvider. Brought up in a tangential code review using the same pattern: http://codereview.chromium.org/10854173/diff/7004/chrome/browser/ui/views/search_view_controller.cc#newcode415 BUG=none TEST=No unexpected UMA regressions (though some change may be expected). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/autocomplete/search_provider.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
msw
Hey Peter, please take a look; thanks!
8 years, 4 months ago (2012-08-16 08:25:51 UTC) #1
msw
ping
8 years, 4 months ago (2012-08-17 19:45:38 UTC) #2
msw
Peter: ping; lmk if I should bug someone else.
8 years, 4 months ago (2012-08-20 22:24:13 UTC) #3
msw
Hey Mark, can you take a look? Thanks!
8 years, 4 months ago (2012-08-21 20:31:56 UTC) #4
Mark P
On 2012/08/21 20:31:56, msw wrote: > Hey Mark, can you take a look? Thanks! lgtm ...
8 years, 4 months ago (2012-08-21 21:07:29 UTC) #5
msw
+ben for OWNERS; please take a look, thanks!
8 years, 4 months ago (2012-08-21 21:08:18 UTC) #6
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-08-21 21:44:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10832338/1
8 years, 4 months ago (2012-08-21 22:11:03 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-21 23:50:05 UTC) #9
Change committed as 152671

Powered by Google App Engine
This is Rietveld 408576698